You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2019/10/26 22:13:57 UTC

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2180: Fix firstStoredEntryId logic in LedgerFragment

eolivelli commented on a change in pull request #2180: Fix firstStoredEntryId logic in LedgerFragment
URL: https://github.com/apache/bookkeeper/pull/2180#discussion_r339317741
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragment.java
 ##########
 @@ -131,16 +131,18 @@ public BookieSocketAddress getAddress(int bookieIndex) {
      * @return entryId
      */
     public long getFirstStoredEntryId() {
-        Long firstEntry = null;
+        Long firstEntry = LedgerHandle.INVALID_ENTRY_ID;
 
 Review comment:
   this can be 'long' instead of 'Long'

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services