[jira] [Comment Edited] (DRILL-1909) Fix SendingAccountor thread safety

["Jacques Nadeau (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261650#comment-14261650 ] 

Jacques Nadeau edited comment on DRILL-1909 at 12/30/14 11:32 PM:
------------------------------------------------------------------

As this was initially designed, the expectation was that increment and waitForSendComplete() should always only be called from one thread.  Clearly this should be documented.  If we're failing to follow this paradigm, we should decide whether we should follow the paradigm or change the thread safety characteristics.
 


was (Author: jnadeau):
As this was initially designed, the expectation was that increment and waitForSendComplete() should always only be called from one thread.  Clearly this should be documented.  If we're failing to follow paradigm, we should decide whether we should follow the paradigm or change the thread safety characteristics.
 

> Fix SendingAccountor thread safety
> ----------------------------------
>
>                 Key: DRILL-1909
>                 URL: https://issues.apache.org/jira/browse/DRILL-1909
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>            Reporter: Daniel Barclay (Drill/MapR)
>            Assignee: Daniel Barclay (Drill/MapR)
>
> SendingAccountor's increment() method is not synchronized, but both it and (already synchronized) method waitForSendComplete() both modify the same variable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)