[GitHub] [airflow] vincbeck commented on a diff in pull request #32573: remove provider specific helper in favor of equivalent one in core

["vincbeck (via GitHub)" <gi...@apache.org>]

vincbeck commented on code in PR #32573:
URL: https://github.com/apache/airflow/pull/32573#discussion_r1262699596


##########
airflow/providers/amazon/aws/utils/__init__.py:
##########
@@ -21,13 +21,17 @@
 from datetime import datetime
 from enum import Enum
 
+from deprecated import deprecated
+
+from airflow.utils.helpers import prune_dict
 from airflow.version import version
 
 log = logging.getLogger(__name__)
 
 
+@deprecated(reason="use prune_dict() instead")

Review Comment:
   nit: maybe more specific?
   ```suggestion
   @deprecated(reason="use airflow.utils.helpers.prune_dict() instead")
   ```



##########
airflow/providers/amazon/aws/utils/__init__.py:
##########
@@ -21,13 +21,17 @@
 from datetime import datetime
 from enum import Enum
 
+from deprecated import deprecated
+
+from airflow.utils.helpers import prune_dict
 from airflow.version import version
 
 log = logging.getLogger(__name__)
 
 
+@deprecated(reason="use prune_dict() instead")

Review Comment:
   nit: maybe be more specific?
   ```suggestion
   @deprecated(reason="use airflow.utils.helpers.prune_dict() instead")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org