You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "Micah Kornfield (JIRA)" <ji...@apache.org> on 2019/02/08 05:34:00 UTC

[jira] [Commented] (ARROW-4264) [C++] Document why DCHECKs are used in kernels

    [ https://issues.apache.org/jira/browse/ARROW-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763339#comment-16763339 ] 

Micah Kornfield commented on ARROW-4264:
----------------------------------------

Based on the discussion I am OK continuing with DCHECKS, I've updated this Jira to document guidelines for using them on kernels.

> [C++] Document why DCHECKs are used in kernels
> ----------------------------------------------
>
>                 Key: ARROW-4264
>                 URL: https://issues.apache.org/jira/browse/ARROW-4264
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Micah Kornfield
>            Assignee: Micah Kornfield
>            Priority: Minor
>
> DCHECKs seem to be used where Status::Invalid might be considered more appropriate (so programs don't crash).  See conversation on [https://github.com/apache/arrow/pull/3287/files]
> based on conversation on this Jira and on the CL it seems DCHECKS are in fact desired but we should document appropriate use for them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)