[GitHub] [cordova-plugin-file] erisu commented on pull request #513: feat(android): add WebViewAssetLoader proxy handler for cdvfile

[GitBox <gi...@apache.org>]

erisu commented on pull request #513:
URL: https://github.com/apache/cordova-plugin-file/pull/513#issuecomment-1051556433


   > Sorry if this is the wrong place to ask, but as the current latest version is from 2019, once this gets merged how long is it likely to be for a new release to be available?
   > 
   > Or will I need to build the plugin myself somehow rather than using cordova plugin add... ?
   
   @skmbr I can not give you an exact answer, but hoping to prepare a release shortly after.
   
   This PR fixes a lot of the issues but I am trying to investigate one alternative solution.
   
   I am hoping with the alternative solution I will not need to introduce new front-end JS code (E.g. `getCdvURL()`). I am hoping to reuse the `toInternalURL()` method instead.
   
   My vision of the alternative solution's use cases is:
   
   1. If `AndroidInsecureFileModeEnabled` = `true`, `toInternalURL()` will continue to return the `file://` URL as it does today.
   1. If `AndroidInsecureFileModeEnabled` is not defined (`false`), `toInternalURL()` will return the `scheme` + `hostname` combination URL. This URL is created from the native side and what would be in the FileEntity object.
   
   Because `toURL` already calls `toInternalURL`, this alternative change would mean that app developers do not need to update or change their front-end code. Simply updating the plugin would be all that is needed.
   
   As a side note, the alternative solution would still use all of the native changes I made in this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org