You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "the-other-tim-brown (via GitHub)" <gi...@apache.org> on 2025/04/17 14:56:22 UTC
[PR] [HUDI-8072] Fix java client functionality for MOR tables, re-enable disabled test for Hive File Group Reader [hudi]
the-other-tim-brown opened a new pull request, #13165:
URL: https://github.com/apache/hudi/pull/13165
### Change Logs
- Adds MoR specific action executors to fix functionality in the java client. Specifically we were seeing that all inserts were resulting in base files even when using the in-memory index which should result in only log files being written
- Updates a java client test to assert this functionality with in-memory index
- Re-enable the test in `TestHoodieFileGroupReaderOnHive`
### Impact
- Fixes functionality for the java client when the index supports indexing of log files, which is required for the FileGroupReader functional test suite
### Risk level (write none, low medium or high below)
None, this follows the pattern used by the spark client and there are existing functional tests around the java client to ensure existing functionality does not break as a result
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8072] Fix java client functionality for MOR tables, re-enable disabled test for Hive File Group Reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13165:
URL: https://github.com/apache/hudi/pull/13165#issuecomment-2813470645
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4928",
"triggerID" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"triggerType" : "PUSH"
}, {
"hash" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4929",
"triggerID" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"triggerType" : "PUSH"
}, {
"hash" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6274eebd3f1f25973ed353b455c699d61e8be5c6 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4929)
* ab3406a322185afe7e3c69fc718fe20ecbb93350 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8072] Fix java client functionality for MOR tables, re-enable disabled test for Hive File Group Reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13165:
URL: https://github.com/apache/hudi/pull/13165#issuecomment-2814109620
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4928",
"triggerID" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"triggerType" : "PUSH"
}, {
"hash" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4929",
"triggerID" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"triggerType" : "PUSH"
}, {
"hash" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4930",
"triggerID" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"triggerType" : "PUSH"
}, {
"hash" : "001d779e4371172df0654bc3b13df5aaffb712f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4932",
"triggerID" : "001d779e4371172df0654bc3b13df5aaffb712f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 001d779e4371172df0654bc3b13df5aaffb712f9 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4932)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8072] Fix java client functionality for MOR tables, re-enable disabled test for Hive File Group Reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13165:
URL: https://github.com/apache/hudi/pull/13165#issuecomment-2813467568
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4928",
"triggerID" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"triggerType" : "PUSH"
}, {
"hash" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4929",
"triggerID" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"triggerType" : "PUSH"
}, {
"hash" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a0bb54626de86f716fdea6ec1147bd7d536e8a3 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4928)
* 6274eebd3f1f25973ed353b455c699d61e8be5c6 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4929)
* ab3406a322185afe7e3c69fc718fe20ecbb93350 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8072] Fix java client functionality for MOR tables, re-enable disabled test for Hive File Group Reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13165:
URL: https://github.com/apache/hudi/pull/13165#issuecomment-2813564381
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4928",
"triggerID" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"triggerType" : "PUSH"
}, {
"hash" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4929",
"triggerID" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"triggerType" : "PUSH"
}, {
"hash" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4930",
"triggerID" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6274eebd3f1f25973ed353b455c699d61e8be5c6 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4929)
* ab3406a322185afe7e3c69fc718fe20ecbb93350 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4930)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8072] Fix java client functionality for MOR tables, re-enable disabled test for Hive File Group Reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13165:
URL: https://github.com/apache/hudi/pull/13165#issuecomment-2815576978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4928",
"triggerID" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"triggerType" : "PUSH"
}, {
"hash" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4929",
"triggerID" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"triggerType" : "PUSH"
}, {
"hash" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4930",
"triggerID" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"triggerType" : "PUSH"
}, {
"hash" : "001d779e4371172df0654bc3b13df5aaffb712f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4932",
"triggerID" : "001d779e4371172df0654bc3b13df5aaffb712f9",
"triggerType" : "PUSH"
}, {
"hash" : "e9f02f9b129c8d8f50070a842c6da7e2644cc5fd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4950",
"triggerID" : "e9f02f9b129c8d8f50070a842c6da7e2644cc5fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 001d779e4371172df0654bc3b13df5aaffb712f9 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4932)
* e9f02f9b129c8d8f50070a842c6da7e2644cc5fd Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4950)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8072] Fix java client functionality for MOR tables, re-enable disabled test for Hive File Group Reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13165:
URL: https://github.com/apache/hudi/pull/13165#issuecomment-2815574346
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4928",
"triggerID" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"triggerType" : "PUSH"
}, {
"hash" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4929",
"triggerID" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"triggerType" : "PUSH"
}, {
"hash" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4930",
"triggerID" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"triggerType" : "PUSH"
}, {
"hash" : "001d779e4371172df0654bc3b13df5aaffb712f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4932",
"triggerID" : "001d779e4371172df0654bc3b13df5aaffb712f9",
"triggerType" : "PUSH"
}, {
"hash" : "e9f02f9b129c8d8f50070a842c6da7e2644cc5fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e9f02f9b129c8d8f50070a842c6da7e2644cc5fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 001d779e4371172df0654bc3b13df5aaffb712f9 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4932)
* e9f02f9b129c8d8f50070a842c6da7e2644cc5fd UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8072] Fix java client functionality for MOR tables, re-enable disabled test for Hive File Group Reader [hudi]
Posted by "jonvex (via GitHub)" <gi...@apache.org>.
jonvex merged PR #13165:
URL: https://github.com/apache/hudi/pull/13165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8072] Fix java client functionality for MOR tables, re-enable disabled test for Hive File Group Reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13165:
URL: https://github.com/apache/hudi/pull/13165#issuecomment-2815704465
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4928",
"triggerID" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"triggerType" : "PUSH"
}, {
"hash" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4929",
"triggerID" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"triggerType" : "PUSH"
}, {
"hash" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4930",
"triggerID" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"triggerType" : "PUSH"
}, {
"hash" : "001d779e4371172df0654bc3b13df5aaffb712f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4932",
"triggerID" : "001d779e4371172df0654bc3b13df5aaffb712f9",
"triggerType" : "PUSH"
}, {
"hash" : "e9f02f9b129c8d8f50070a842c6da7e2644cc5fd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4950",
"triggerID" : "e9f02f9b129c8d8f50070a842c6da7e2644cc5fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e9f02f9b129c8d8f50070a842c6da7e2644cc5fd Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4950)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8072] Fix java client functionality for MOR tables, re-enable disabled test for Hive File Group Reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13165:
URL: https://github.com/apache/hudi/pull/13165#issuecomment-2813985845
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4928",
"triggerID" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"triggerType" : "PUSH"
}, {
"hash" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4929",
"triggerID" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"triggerType" : "PUSH"
}, {
"hash" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4930",
"triggerID" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"triggerType" : "PUSH"
}, {
"hash" : "001d779e4371172df0654bc3b13df5aaffb712f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4932",
"triggerID" : "001d779e4371172df0654bc3b13df5aaffb712f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ab3406a322185afe7e3c69fc718fe20ecbb93350 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4930)
* 001d779e4371172df0654bc3b13df5aaffb712f9 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4932)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8072] Fix java client functionality for MOR tables, re-enable disabled test for Hive File Group Reader [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13165:
URL: https://github.com/apache/hudi/pull/13165#discussion_r2050637494
##########
hudi-client/hudi-java-client/src/main/java/org/apache/hudi/table/action/deltacommit/BaseJavaDeltaCommitActionExecutor.java:
##########
@@ -69,4 +82,15 @@ public Iterator<List<WriteStatus>> handleUpdate(String partitionPath, String fil
return Collections.singletonList(appendHandle.close()).iterator();
}
}
+
+ @Override
+ public Iterator<List<WriteStatus>> handleInsert(String idPfx, Iterator<HoodieRecord<T>> recordItr) {
Review Comment:
No need to use shortening here since `idPrefix` is not long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8072] Fix java client functionality for MOR tables, re-enable disabled test for Hive File Group Reader [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #13165:
URL: https://github.com/apache/hudi/pull/13165#discussion_r2050721376
##########
hudi-client/hudi-java-client/src/main/java/org/apache/hudi/table/action/deltacommit/BaseJavaDeltaCommitActionExecutor.java:
##########
@@ -69,4 +82,15 @@ public Iterator<List<WriteStatus>> handleUpdate(String partitionPath, String fil
return Collections.singletonList(appendHandle.close()).iterator();
}
}
+
+ @Override
+ public Iterator<List<WriteStatus>> handleInsert(String idPfx, Iterator<HoodieRecord<T>> recordItr) {
Review Comment:
This is matching the variable naming used in the interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8072] Fix java client functionality for MOR tables, re-enable disabled test for Hive File Group Reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13165:
URL: https://github.com/apache/hudi/pull/13165#issuecomment-2813983409
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4928",
"triggerID" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"triggerType" : "PUSH"
}, {
"hash" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4929",
"triggerID" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"triggerType" : "PUSH"
}, {
"hash" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4930",
"triggerID" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"triggerType" : "PUSH"
}, {
"hash" : "001d779e4371172df0654bc3b13df5aaffb712f9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "001d779e4371172df0654bc3b13df5aaffb712f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ab3406a322185afe7e3c69fc718fe20ecbb93350 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4930)
* 001d779e4371172df0654bc3b13df5aaffb712f9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8072] Fix java client functionality for MOR tables, re-enable disabled test for Hive File Group Reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13165:
URL: https://github.com/apache/hudi/pull/13165#issuecomment-2813222530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a0bb54626de86f716fdea6ec1147bd7d536e8a3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8072] Fix java client functionality for MOR tables, re-enable disabled test for Hive File Group Reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13165:
URL: https://github.com/apache/hudi/pull/13165#issuecomment-2813319877
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4928",
"triggerID" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"triggerType" : "PUSH"
}, {
"hash" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a0bb54626de86f716fdea6ec1147bd7d536e8a3 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4928)
* 6274eebd3f1f25973ed353b455c699d61e8be5c6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8072] Fix java client functionality for MOR tables, re-enable disabled test for Hive File Group Reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13165:
URL: https://github.com/apache/hudi/pull/13165#issuecomment-2813229934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4928",
"triggerID" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a0bb54626de86f716fdea6ec1147bd7d536e8a3 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4928)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8072] Fix java client functionality for MOR tables, re-enable disabled test for Hive File Group Reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13165:
URL: https://github.com/apache/hudi/pull/13165#issuecomment-2813702925
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4928",
"triggerID" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"triggerType" : "PUSH"
}, {
"hash" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4929",
"triggerID" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"triggerType" : "PUSH"
}, {
"hash" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4930",
"triggerID" : "ab3406a322185afe7e3c69fc718fe20ecbb93350",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ab3406a322185afe7e3c69fc718fe20ecbb93350 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4930)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8072] Fix java client functionality for MOR tables, re-enable disabled test for Hive File Group Reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13165:
URL: https://github.com/apache/hudi/pull/13165#issuecomment-2813314255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4928",
"triggerID" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"triggerType" : "PUSH"
}, {
"hash" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a0bb54626de86f716fdea6ec1147bd7d536e8a3 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4928)
* 6274eebd3f1f25973ed353b455c699d61e8be5c6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8072] Fix java client functionality for MOR tables, re-enable disabled test for Hive File Group Reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13165:
URL: https://github.com/apache/hudi/pull/13165#issuecomment-2813430891
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4928",
"triggerID" : "9a0bb54626de86f716fdea6ec1147bd7d536e8a3",
"triggerType" : "PUSH"
}, {
"hash" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4929",
"triggerID" : "6274eebd3f1f25973ed353b455c699d61e8be5c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a0bb54626de86f716fdea6ec1147bd7d536e8a3 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4928)
* 6274eebd3f1f25973ed353b455c699d61e8be5c6 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4929)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org