You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by hansdude <gi...@git.apache.org> on 2015/03/29 23:18:43 UTC

[GitHub] thrift pull request: THRIFT-3050 TLS Client cert validation TLS C#

GitHub user hansdude opened a pull request:

    https://github.com/apache/thrift/pull/410

    THRIFT-3050 TLS Client cert validation TLS C#

    This plumbs the remote certificate validation callback down
    to the server side authentication code. When the callback is
    set, we set the client certificate required flag. In practice, the
    validation callback still gets called even when the client
    doesn't supply a certificate.
    
    I've taken the liberty of using slightly more modern C# syntax
    to shorten up the affected method.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hansdude/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/410.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #410
    
----
commit 45d750c5fc9502e3b17c5260b9ab9080bc152eab
Author: Hans-Peter Klett <ha...@spectralogic.com>
Date:   2015-03-29T21:10:16Z

    THRIFT-3050 TLS Client cert validation TLS C#
    
    This plumbs the remote certificate validation callback down
    to the server side authentication code. When the callback is
    set, we set the client certificate required flag. In practice, the
    validation callback still gets called even when the client
    doesn't supply a certificate.
    
    I've taken the liberty of using slightly more modern C# syntax
    to shorten up the affected method.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3050 TLS Client cert validation TLS C#

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/410


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---