You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2026/09/30 17:43:44 UTC
[Impala-ASF-CR] IMPALA-11917: Qualify enum values in compression-util.cc
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24985
Change subject: IMPALA-11917: Qualify enum values in compression-util.cc
......................................................................
IMPALA-11917: Qualify enum values in compression-util.cc
Qualifies the case labels in THdfsCompressionToProto() and
CompressionTypePBToThrift() with their enum names instead of relying on
unscoped lookup of the enumerators.
Change-Id: Iae882884a694a652ab5ef6835c07a58dcf675106
Assisted-by: Claude Sonnet 5.5 (GitHub Copilot)
---
M be/src/util/compression-util.cc
1 file changed, 26 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/24985/1
--
To view, visit http://gerrit.cloudera.org:8080/24985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae882884a694a652ab5ef6835c07a58dcf675106
Gerrit-Change-Number: 24985
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11917: Qualify enum values in compression-util.cc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24985 )
Change subject: IMPALA-11917: Qualify enum values in compression-util.cc
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14178/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae882884a694a652ab5ef6835c07a58dcf675106
Gerrit-Change-Number: 24985
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Sep 2026 19:44:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11917: Qualify enum values in compression-util.cc
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24985 )
Change subject: IMPALA-11917: Qualify enum values in compression-util.cc
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae882884a694a652ab5ef6835c07a58dcf675106
Gerrit-Change-Number: 24985
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Sep 2026 18:52:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11917: Qualify enum values in compression-util.cc
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24985 )
Change subject: IMPALA-11917: Qualify enum values in compression-util.cc
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae882884a694a652ab5ef6835c07a58dcf675106
Gerrit-Change-Number: 24985
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Oct 2026 19:41:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11917: Qualify enum values in compression-util.cc
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24985 )
Change subject: IMPALA-11917: Qualify enum values in compression-util.cc
......................................................................
Patch Set 2: Verified+1 Code-Review+2
Carry prior approval.
--
To view, visit http://gerrit.cloudera.org:8080/24985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae882884a694a652ab5ef6835c07a58dcf675106
Gerrit-Change-Number: 24985
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Oct 2026 15:44:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11917: Qualify enum values in compression-util.cc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24985 )
Change subject: IMPALA-11917: Qualify enum values in compression-util.cc
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae882884a694a652ab5ef6835c07a58dcf675106
Gerrit-Change-Number: 24985
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Oct 2026 00:14:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11917: Qualify enum values in compression-util.cc
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24985 )
Change subject: IMPALA-11917: Qualify enum values in compression-util.cc
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae882884a694a652ab5ef6835c07a58dcf675106
Gerrit-Change-Number: 24985
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Oct 2026 00:31:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11917: Qualify enum values in compression-util.cc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24985 )
Change subject: IMPALA-11917: Qualify enum values in compression-util.cc
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/24267/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae882884a694a652ab5ef6835c07a58dcf675106
Gerrit-Change-Number: 24985
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Sep 2026 18:09:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11917: Qualify enum values in compression-util.cc
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24985 )
Change subject: IMPALA-11917: Qualify enum values in compression-util.cc
......................................................................
IMPALA-11917: Qualify enum values in compression-util.cc
Qualifies the case labels in THdfsCompressionToProto() and
CompressionTypePBToThrift() with their enum names instead of relying on
unscoped lookup of the enumerators.
Change-Id: Iae882884a694a652ab5ef6835c07a58dcf675106
Assisted-by: Claude Sonnet 5.5 (GitHub Copilot)
Reviewed-on: http://gerrit.cloudera.org:8080/24985
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M be/src/util/compression-util.cc
1 file changed, 26 insertions(+), 26 deletions(-)
Approvals:
Michael Smith: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/24985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae882884a694a652ab5ef6835c07a58dcf675106
Gerrit-Change-Number: 24985
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>