You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by li...@apache.org on 2023/08/28 14:09:26 UTC

[arrow] branch main updated: GH-37406: [C++][FlightSQL] Add missing ArrowFlight::arrow_flight_{shared,static} dependencies (#37407)

This is an automated email from the ASF dual-hosted git repository.

lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 78b0c10cca GH-37406: [C++][FlightSQL] Add missing ArrowFlight::arrow_flight_{shared,static} dependencies (#37407)
78b0c10cca is described below

commit 78b0c10cca226178cb5921c3cec3b85530f818ad
Author: Sutou Kouhei <ko...@clear-code.com>
AuthorDate: Mon Aug 28 23:09:19 2023 +0900

    GH-37406: [C++][FlightSQL] Add missing ArrowFlight::arrow_flight_{shared,static} dependencies (#37407)
    
    ### Rationale for this change
    
    `ArrowFlightSql::arrow_flight_sql_shared` must depend on `ArrowFlight::arrow_flight_shared` because `arrow/flight/sql/*.h` uses ` arrow/flight/*.h` and all users must use Flight RPC API with Flight SQL API.
    
    ### What changes are included in this PR?
    
    Add missing `{SHARED,STATIC}_INSTALL_INTERFACE_LIBS`.
    
    ### Are these changes tested?
    
    Yes.
    
    ### Are there any user-facing changes?
    
    Yes.
    * Closes: #37406
    
    Authored-by: Sutou Kouhei <ko...@clear-code.com>
    Signed-off-by: David Li <li...@gmail.com>
---
 cpp/src/arrow/flight/sql/CMakeLists.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/cpp/src/arrow/flight/sql/CMakeLists.txt b/cpp/src/arrow/flight/sql/CMakeLists.txt
index 0f12dbfdf9..b0a551a2bc 100644
--- a/cpp/src/arrow/flight/sql/CMakeLists.txt
+++ b/cpp/src/arrow/flight/sql/CMakeLists.txt
@@ -64,8 +64,12 @@ add_arrow_lib(arrow_flight_sql
               ${ARROW_VERSION_SCRIPT_FLAGS} # Defined in cpp/arrow/CMakeLists.txt
               SHARED_LINK_LIBS
               arrow_flight_shared
+              SHARED_INSTALL_INTERFACE_LIBS
+              ArrowFlight::arrow_flight_shared
               STATIC_LINK_LIBS
               arrow_flight_static
+              STATIC_INSTALL_INTERFACE_LIBS
+              ArrowFlight::arrow_flight_static
               PRIVATE_INCLUDES
               "${Protobuf_INCLUDE_DIRS}")