You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@causeway.apache.org by ah...@apache.org on 2023/07/24 08:41:22 UTC

[causeway] branch master updated: CAUSEWAY-3532: just comments

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/causeway.git


The following commit(s) were added to refs/heads/master by this push:
     new 6321f485a9 CAUSEWAY-3532: just comments
6321f485a9 is described below

commit 6321f485a91879d1ff3a5d675b9df8cb5113b5da
Author: andi-huber <ah...@apache.org>
AuthorDate: Mon Jul 24 10:41:17 2023 +0200

    CAUSEWAY-3532: just comments
---
 .../causeway/testdomain/viewers/jdo/wkt/InteractionTestJdoWkt.java  | 5 +----
 .../causeway/testdomain/viewers/jpa/wkt/InteractionTestJpaWkt.java  | 6 +-----
 .../apache/causeway/testdomain/conf/Configuration_usingWicket.java  | 2 ++
 3 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/regressiontests/stable-viewers-jdo/src/test/java/org/apache/causeway/testdomain/viewers/jdo/wkt/InteractionTestJdoWkt.java b/regressiontests/stable-viewers-jdo/src/test/java/org/apache/causeway/testdomain/viewers/jdo/wkt/InteractionTestJdoWkt.java
index 96b1ae56e3..085d501db3 100644
--- a/regressiontests/stable-viewers-jdo/src/test/java/org/apache/causeway/testdomain/viewers/jdo/wkt/InteractionTestJdoWkt.java
+++ b/regressiontests/stable-viewers-jdo/src/test/java/org/apache/causeway/testdomain/viewers/jdo/wkt/InteractionTestJdoWkt.java
@@ -256,17 +256,14 @@ class InteractionTestJdoWkt extends RegressionTestWithJdoFixtures {
             return wktTester.createPageParameters(jdoBook);
         });
 
-        //System.err.printf("pageParameters %s%n", pageParameters);
-
         // open Dune page and click on the Delete action
         run(()->{
             wktTester.startEntityPage(pageParameters);
             wktTester.clickLink(BOOK_DELETE_ACTION_JDO);
 
+            // then should render a standalone collection labeled 'Delete'
             val label = (Label)wktTester
                     .getComponentFromLastRenderedPage(STANDALONE_COLLECTION_LABEL);
-
-            // then should render a standalone collection labeled 'Delete'
             assertEquals("Delete", label.getDefaultModelObject());
         });
     }
diff --git a/regressiontests/stable-viewers-jpa/src/test/java/org/apache/causeway/testdomain/viewers/jpa/wkt/InteractionTestJpaWkt.java b/regressiontests/stable-viewers-jpa/src/test/java/org/apache/causeway/testdomain/viewers/jpa/wkt/InteractionTestJpaWkt.java
index 8285ba0746..ee2e7f41bc 100644
--- a/regressiontests/stable-viewers-jpa/src/test/java/org/apache/causeway/testdomain/viewers/jpa/wkt/InteractionTestJpaWkt.java
+++ b/regressiontests/stable-viewers-jpa/src/test/java/org/apache/causeway/testdomain/viewers/jpa/wkt/InteractionTestJpaWkt.java
@@ -276,18 +276,14 @@ class InteractionTestJpaWkt extends RegressionTestWithJpaFixtures {
             return wktTester.createPageParameters(jpaBook);
         });
 
-        //System.err.printf("pageParameters %s%n", pageParameters);
-
         // open Dune page and click on the Delete action
         run(()->{
             wktTester.startEntityPage(pageParameters);
-            wktTester.dumpComponentTree(comp->true);
             wktTester.clickLink(BOOK_DELETE_ACTION_JPA);
 
+            // then should render a standalone collection labeled 'Delete'
             val label = (Label)wktTester
                     .getComponentFromLastRenderedPage(STANDALONE_COLLECTION_LABEL);
-
-            // then should render a standalone collection labeled 'Delete'
             assertEquals("Delete", label.getDefaultModelObject());
         });
     }
diff --git a/regressiontests/stable/src/main/java/org/apache/causeway/testdomain/conf/Configuration_usingWicket.java b/regressiontests/stable/src/main/java/org/apache/causeway/testdomain/conf/Configuration_usingWicket.java
index 8695d8dde5..5355ce8c7e 100644
--- a/regressiontests/stable/src/main/java/org/apache/causeway/testdomain/conf/Configuration_usingWicket.java
+++ b/regressiontests/stable/src/main/java/org/apache/causeway/testdomain/conf/Configuration_usingWicket.java
@@ -109,6 +109,7 @@ public class Configuration_usingWicket {
 
         // -- BOOK PAGE
 
+        /** strange asymmetry with JPA, to investigate another day */
         public static final String BOOK_DELETE_ACTION_JDO = "theme:entityPageContainer:entity:rows:2"
                 + ":rowContents:1"
                 + ":col:rows:1:rowContents:1:col:tabGroups:1"
@@ -118,6 +119,7 @@ public class Configuration_usingWicket {
                 + ":panelHeading:associatedActionLinksPanel"
                 + ":additionalLinkList:additionalLinkItem:0:additionalLink";
 
+        /** strange asymmetry with JDO, to investigate another day */
         public static final String BOOK_DELETE_ACTION_JPA = "theme:entityPageContainer:entity:rows:2"
                 + ":rowContents:1"
                 + ":col:rows:1:rowContents:1:col:tabGroups:1:1:rowContents:1"