You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by lifei <gi...@git.apache.org> on 2016/10/12 19:36:55 UTC

[GitHub] mina-sshd pull request #26: [SSHD-705] fix GSSAPI Auth breaken

GitHub user lifei opened a pull request:

    https://github.com/apache/mina-sshd/pull/26

    [SSHD-705] fix GSSAPI Auth breaken

    GSSAPI auth is breaken after changing username with getUserName().
    
    https://github.com/apache/mina-sshd/commit/d19f5eca5714b7055b8655a46aeba0629c9dc05a#diff-6632304d23a69cec2f1da01ee1b4eb8fL127
    
    ```
    -  msgbuf.putString(username);
    + msgbuf.putString(getUserName());
    ```
    
    https://github.com/apache/mina-sshd/commit/d19f5eca5714b7055b8655a46aeba0629c9dc05a#diff-6632304d23a69cec2f1da01ee1b4eb8fL185
    
    ```
    -  return identity != null ? identity : username;
    + return identity != null ? identity : super.getUserName();
    ```
    
    getUserName() is not equals with username when identity is not null.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lifei/mina-sshd patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/mina-sshd/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #26
    
----
commit 2ca5013dfdf220e589fc29195f5933202d8ece99
Author: \u8f6f\u4ef6\u5de5\u7a0b\u5e08\u674e\u98db <li...@7v1.net>
Date:   2016-10-12T19:36:35Z

    [SSHD-705] fix GSSAPI Auth breaken
    
    GSSAPI auth is breaken after changing username with getUserName().
    
    https://github.com/apache/mina-sshd/commit/d19f5eca5714b7055b8655a46aeba0629c9dc05a#diff-6632304d23a69cec2f1da01ee1b4eb8fL127
    
    ```
    -  msgbuf.putString(username);
    + msgbuf.putString(getUserName());
    ```
    
    https://github.com/apache/mina-sshd/commit/d19f5eca5714b7055b8655a46aeba0629c9dc05a#diff-6632304d23a69cec2f1da01ee1b4eb8fL185
    
    ```
    -  return identity != null ? identity : username;
    + return identity != null ? identity : super.getUserName();
    ```
    
    getUserName() is not equals with username when identity is not null.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] mina-sshd pull request #26: [SSHD-705] fix GSSAPI Auth breaken

Posted by lifei <gi...@git.apache.org>.
Github user lifei closed the pull request at:

    https://github.com/apache/mina-sshd/pull/26


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---