You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/08 09:26:02 UTC

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2319: LUCENE-9743: Hunspell: ignore original tests which are out of scope

donnerpeter opened a new pull request #2319:
URL: https://github.com/apache/lucene-solr/pull/2319


   <!--
   _(If you are a project committer then you may remove some/all of the following template.)_
   
   Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
   
   * https://issues.apache.org/jira/projects/LUCENE
   * https://issues.apache.org/jira/projects/SOLR
   
   You will need to create an account in Jira in order to create an issue.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * LUCENE-####: <short description of problem or changes>
   * SOLR-####: <short description of problem or changes>
   
   LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
   
   
   # Description
   
   Some of the original Hunspell's tests are out of scope of LUCENE-9687: Hunspell support improvements
   
   # Solution
   
   Make their failures expected for now. Plus check suggestions in `TestHunspellRepositoryTestCases`.
   
   # Tests
   
   The change itself is only about tests. `TestHunspellRepositoryTestCases` still fails and needs to be fixed.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request title.
   - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `master` branch.
   - [x] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2319: LUCENE-9743: Hunspell: ignore original tests which are out of scope

Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #2319:
URL: https://github.com/apache/lucene-solr/pull/2319#discussion_r571923906



##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestHunspellRepositoryTestCases.java
##########
@@ -36,9 +37,18 @@
  */
 @RunWith(Parameterized.class)
 public class TestHunspellRepositoryTestCases {
+  private static final Set<String> IGNORED =
+      Set.of(
+          "hu", // Hungarian is hard: a lot of its rules are hardcoded in Hunspell code, not aff/dic

Review comment:
       The irony is that "hun" in "hunspell" means it was initially created for Hungarian, but its declarative options still aren't enough to describe it :(

##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestHunspellRepositoryTestCases.java
##########
@@ -64,7 +74,12 @@ public TestHunspellRepositoryTestCases(String testName, Path pathPrefix) {
   }
 
   @Test
-  public void test() throws IOException, ParseException {
-    SpellCheckerTest.checkSpellCheckerExpectations(pathPrefix, false);
+  public void test() throws Throwable {
+    ThrowingRunnable test = () -> SpellCheckerTest.checkSpellCheckerExpectations(pathPrefix);
+    if (IGNORED.contains(testName)) {

Review comment:
       Renamed, thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2319: LUCENE-9743: Hunspell: ignore original tests which are out of scope

Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #2319:
URL: https://github.com/apache/lucene-solr/pull/2319#discussion_r571951218



##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestHunspellRepositoryTestCases.java
##########
@@ -36,9 +37,18 @@
  */
 @RunWith(Parameterized.class)
 public class TestHunspellRepositoryTestCases {
+  private static final Set<String> IGNORED =
+      Set.of(
+          "hu", // Hungarian is hard: a lot of its rules are hardcoded in Hunspell code, not aff/dic

Review comment:
       Yes, they're quite unusual. I've studied Finnish a bit, and it was fun.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] dweiss merged pull request #2319: LUCENE-9743: Hunspell: ignore original tests which are out of scope

Posted by GitBox <gi...@apache.org>.
dweiss merged pull request #2319:
URL: https://github.com/apache/lucene-solr/pull/2319


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] dweiss commented on a change in pull request #2319: LUCENE-9743: Hunspell: ignore original tests which are out of scope

Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #2319:
URL: https://github.com/apache/lucene-solr/pull/2319#discussion_r571949071



##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestHunspellRepositoryTestCases.java
##########
@@ -36,9 +37,18 @@
  */
 @RunWith(Parameterized.class)
 public class TestHunspellRepositoryTestCases {
+  private static final Set<String> IGNORED =
+      Set.of(
+          "hu", // Hungarian is hard: a lot of its rules are hardcoded in Hunspell code, not aff/dic

Review comment:
       Whenever I come across Finno-Ugric languages I always end up with a conclusion that they must be alien descendants left over on Earth... (and I have friends speaking Hungarian!).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] dweiss commented on a change in pull request #2319: LUCENE-9743: Hunspell: ignore original tests which are out of scope

Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #2319:
URL: https://github.com/apache/lucene-solr/pull/2319#discussion_r571918529



##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestHunspellRepositoryTestCases.java
##########
@@ -64,7 +74,12 @@ public TestHunspellRepositoryTestCases(String testName, Path pathPrefix) {
   }
 
   @Test
-  public void test() throws IOException, ParseException {
-    SpellCheckerTest.checkSpellCheckerExpectations(pathPrefix, false);
+  public void test() throws Throwable {
+    ThrowingRunnable test = () -> SpellCheckerTest.checkSpellCheckerExpectations(pathPrefix);
+    if (IGNORED.contains(testName)) {

Review comment:
       It should perhaps read FAILING instead of ignored if you're still running the test and testing the outcome? 

##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestHunspellRepositoryTestCases.java
##########
@@ -36,9 +37,18 @@
  */
 @RunWith(Parameterized.class)
 public class TestHunspellRepositoryTestCases {
+  private static final Set<String> IGNORED =
+      Set.of(
+          "hu", // Hungarian is hard: a lot of its rules are hardcoded in Hunspell code, not aff/dic

Review comment:
       Hungarian is hard, isn't it! :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org