You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/10/09 14:19:46 UTC

[GitHub] [rocketmq] AVP42 opened a new pull request #2343: [ISSUE# 2330]store the properties of MessageBatch

AVP42 opened a new pull request #2343:
URL: https://github.com/apache/rocketmq/pull/2343


   ## What is the purpose of the change
   
   store the properties of MessageBatch 
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-io edited a comment on pull request #2343: [ISSUE# 2330] Store the properties of MessageBatch

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2343:
URL: https://github.com/apache/rocketmq/pull/2343#issuecomment-706330064


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2343?src=pr&el=h1) Report
   > Merging [#2343](https://codecov.io/gh/apache/rocketmq/pull/2343?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/rocketmq/commit/77d24def3a5aafd0d10afd525734bba398cf48b2?el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `87.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/2343/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv)](https://codecov.io/gh/apache/rocketmq/pull/2343?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #2343      +/-   ##
   =============================================
   - Coverage      45.69%   45.67%   -0.02%     
   - Complexity      4289     4291       +2     
   =============================================
     Files            547      547              
     Lines          35971    35979       +8     
     Branches        4770     4773       +3     
   =============================================
   - Hits           16437    16434       -3     
   - Misses         17477    17480       +3     
   - Partials        2057     2065       +8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2343?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...main/java/org/apache/rocketmq/store/CommitLog.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | `67.39% <87.50%> (+0.06%)` | `80.00 <0.00> (ø)` | |
   | [...tmq/logappender/log4j2/RocketmqLog4j2Appender.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-bG9nYXBwZW5kZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2xvZ2FwcGVuZGVyL2xvZzRqMi9Sb2NrZXRtcUxvZzRqMkFwcGVuZGVyLmphdmE=) | `35.00% <0.00%> (-10.00%)` | `3.00% <0.00%> (-1.00%)` | |
   | [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `41.79% <0.00%> (-8.96%)` | `16.00% <0.00%> (-3.00%)` | |
   | [...org/apache/rocketmq/store/ha/WaitNotifyObject.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL1dhaXROb3RpZnlPYmplY3QuamF2YQ==) | `75.00% <0.00%> (-7.70%)` | `10.00% <0.00%> (-1.00%)` | |
   | [...in/java/org/apache/rocketmq/test/util/MQAdmin.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RQWRtaW4uamF2YQ==) | `38.88% <0.00%> (-5.56%)` | `7.00% <0.00%> (-1.00%)` | |
   | [...ketmq/common/protocol/body/ConsumerConnection.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvYm9keS9Db25zdW1lckNvbm5lY3Rpb24uamF2YQ==) | `95.83% <0.00%> (-4.17%)` | `13.00% <0.00%> (-1.00%)` | |
   | [...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=) | `38.98% <0.00%> (-2.53%)` | `16.00% <0.00%> (-3.00%)` | |
   | [.../rocketmq/client/impl/consumer/PullAPIWrapper.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsQVBJV3JhcHBlci5qYXZh) | `50.42% <0.00%> (-0.86%)` | `12.00% <0.00%> (-1.00%)` | |
   | [...n/java/org/apache/rocketmq/store/ha/HAService.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL0hBU2VydmljZS5qYXZh) | `67.88% <0.00%> (-0.67%)` | `18.00% <0.00%> (ø%)` | |
   | [...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==) | `12.09% <0.00%> (-0.54%)` | `24.00% <0.00%> (-1.00%)` | |
   | ... and [14 more](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2343?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2343?src=pr&el=footer). Last update [77d24de...ced727e](https://codecov.io/gh/apache/rocketmq/pull/2343?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on pull request #2343: [ISSUE# 2330] Store the properties of MessageBatch

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #2343:
URL: https://github.com/apache/rocketmq/pull/2343#issuecomment-711249260


   > I don't think the travis error is caused by these commits. Perhaps need to rebuild?
   
   The code is OK, I rebuild the CI.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on a change in pull request #2343: [ISSUE# 2330] Store the properties of MessageBatch

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on a change in pull request #2343:
URL: https://github.com/apache/rocketmq/pull/2343#discussion_r502852616



##########
File path: store/src/main/java/org/apache/rocketmq/store/CommitLog.java
##########
@@ -1871,9 +1878,13 @@ public ByteBuffer encode(final MessageExtBatch messageExtBatch) {
                 this.msgBatchMemory.put((byte) topicLength);
                 this.msgBatchMemory.put(topicData);
                 // 17 PROPERTIES
-                this.msgBatchMemory.putShort(propertiesLen);
-                if (propertiesLen > 0)
+                this.msgBatchMemory.putShort((short) (propertiesLen + batchPropLen));
+                if (propertiesLen > 0) {
                     this.msgBatchMemory.put(messagesByteBuff.array(), propertiesPos, propertiesLen);
+                }
+                if (batchPropLen > 0) {
+                    this.msgBatchMemory.put(batchPropData, 0, batchPropLen);
+                }

Review comment:
       Just put properties of MessageExtBatch into msgBatchMemory. The original code takes the properties of a single message, so it does not exist.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] AVP42 commented on pull request #2343: [ISSUE# 2330] Store the properties of MessageBatch

Posted by GitBox <gi...@apache.org>.
AVP42 commented on pull request #2343:
URL: https://github.com/apache/rocketmq/pull/2343#issuecomment-708386396


   I don't think the travis error is caused by these commits. Perhaps need to rebuild?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] vongosling merged pull request #2343: [ISSUE# 2330] Store the properties of MessageBatch

Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #2343:
URL: https://github.com/apache/rocketmq/pull/2343


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #2343: [ISSUE# 2330]store the properties of MessageBatch

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2343:
URL: https://github.com/apache/rocketmq/pull/2343#issuecomment-706329036


   
   [![Coverage Status](https://coveralls.io/builds/34065595/badge)](https://coveralls.io/builds/34065595)
   
   Coverage increased (+0.03%) to 51.464% when pulling **18e2acc4fda9bfdfc73794cb0518653ff407cc05 on AVP42:batch_properties** into **77d24def3a5aafd0d10afd525734bba398cf48b2 on apache:develop**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #2343: [ISSUE# 2330] Store the properties of MessageBatch

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2343:
URL: https://github.com/apache/rocketmq/pull/2343#issuecomment-706329036


   
   [![Coverage Status](https://coveralls.io/builds/34261546/badge)](https://coveralls.io/builds/34261546)
   
   Coverage increased (+0.09%) to 51.516% when pulling **ced727e63abe3b8c5237a7c0fe3ecc3fdc2ecc47 on AVP42:batch_properties** into **77d24def3a5aafd0d10afd525734bba398cf48b2 on apache:develop**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] AVP42 commented on a change in pull request #2343: [ISSUE# 2330] Store the properties of MessageBatch

Posted by GitBox <gi...@apache.org>.
AVP42 commented on a change in pull request #2343:
URL: https://github.com/apache/rocketmq/pull/2343#discussion_r503877637



##########
File path: broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java
##########
@@ -577,6 +577,7 @@ private RemotingCommand handlePutMessageResult(PutMessageResult putMessageResult
         messageExtBatch.setFlag(requestHeader.getFlag());
         MessageAccessor.setProperties(messageExtBatch, MessageDecoder.string2messageProperties(requestHeader.getProperties()));
         messageExtBatch.setBody(request.getBody());
+        messageExtBatch.setPropertiesString(requestHeader.getProperties());

Review comment:
       Yes, I agree with you. My Intention was to avoid another transformation since there was already a transformed string.  I thought that MessageExtBrokerInner is out of the same consideration. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] AVP42 commented on a change in pull request #2343: [ISSUE# 2330] Store the properties of MessageBatch

Posted by GitBox <gi...@apache.org>.
AVP42 commented on a change in pull request #2343:
URL: https://github.com/apache/rocketmq/pull/2343#discussion_r503878336



##########
File path: store/src/main/java/org/apache/rocketmq/store/CommitLog.java
##########
@@ -1871,9 +1878,13 @@ public ByteBuffer encode(final MessageExtBatch messageExtBatch) {
                 this.msgBatchMemory.put((byte) topicLength);
                 this.msgBatchMemory.put(topicData);
                 // 17 PROPERTIES
-                this.msgBatchMemory.putShort(propertiesLen);
-                if (propertiesLen > 0)
+                this.msgBatchMemory.putShort((short) (propertiesLen + batchPropLen));
+                if (propertiesLen > 0) {
                     this.msgBatchMemory.put(messagesByteBuff.array(), propertiesPos, propertiesLen);
+                }
+                if (batchPropLen > 0) {
+                    this.msgBatchMemory.put(batchPropData, 0, batchPropLen);
+                }

Review comment:
       Sure.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-io commented on pull request #2343: [ISSUE# 2330]store the properties of MessageBatch

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2343:
URL: https://github.com/apache/rocketmq/pull/2343#issuecomment-706330064


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2343?src=pr&el=h1) Report
   > Merging [#2343](https://codecov.io/gh/apache/rocketmq/pull/2343?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/rocketmq/commit/77d24def3a5aafd0d10afd525734bba398cf48b2?el=desc) will **decrease** coverage by `0.09%`.
   > The diff coverage is `61.53%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/2343/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv)](https://codecov.io/gh/apache/rocketmq/pull/2343?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #2343      +/-   ##
   =============================================
   - Coverage      45.69%   45.59%   -0.10%     
   + Complexity      4289     4279      -10     
   =============================================
     Files            547      547              
     Lines          35971    35981      +10     
     Branches        4770     4773       +3     
   =============================================
   - Hits           16437    16407      -30     
   - Misses         17477    17522      +45     
   + Partials        2057     2052       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2343?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ocketmq/broker/processor/SendMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1NlbmRNZXNzYWdlUHJvY2Vzc29yLmphdmE=) | `40.90% <0.00%> (-0.11%)` | `26.00 <0.00> (ø)` | |
   | [...pache/rocketmq/common/message/MessageExtBatch.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vbWVzc2FnZS9NZXNzYWdlRXh0QmF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...main/java/org/apache/rocketmq/store/CommitLog.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | `67.52% <88.88%> (+0.20%)` | `80.00 <0.00> (ø)` | |
   | [...rocketmq/broker/filtersrv/FilterServerManager.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyc3J2L0ZpbHRlclNlcnZlck1hbmFnZXIuamF2YQ==) | `20.00% <0.00%> (-14.29%)` | `5.00% <0.00%> (-2.00%)` | |
   | [...tmq/logappender/log4j2/RocketmqLog4j2Appender.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-bG9nYXBwZW5kZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2xvZ2FwcGVuZGVyL2xvZzRqMi9Sb2NrZXRtcUxvZzRqMkFwcGVuZGVyLmphdmE=) | `35.00% <0.00%> (-10.00%)` | `3.00% <0.00%> (-1.00%)` | |
   | [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `43.28% <0.00%> (-7.47%)` | `17.00% <0.00%> (-2.00%)` | |
   | [...ketmq/common/protocol/body/ConsumerConnection.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvYm9keS9Db25zdW1lckNvbm5lY3Rpb24uamF2YQ==) | `95.83% <0.00%> (-4.17%)` | `13.00% <0.00%> (-1.00%)` | |
   | [...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=) | `38.98% <0.00%> (-2.53%)` | `16.00% <0.00%> (-3.00%)` | |
   | [...rocketmq/client/impl/factory/MQClientInstance.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==) | `46.97% <0.00%> (-0.74%)` | `82.00% <0.00%> (-1.00%)` | |
   | [...etmq/client/latency/LatencyFaultToleranceImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvbGF0ZW5jeS9MYXRlbmN5RmF1bHRUb2xlcmFuY2VJbXBsLmphdmE=) | `50.00% <0.00%> (ø)` | `8.00% <0.00%> (ø%)` | |
   | ... and [2 more](https://codecov.io/gh/apache/rocketmq/pull/2343/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2343?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2343?src=pr&el=footer). Last update [77d24de...18e2acc](https://codecov.io/gh/apache/rocketmq/pull/2343?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on a change in pull request #2343: [ISSUE# 2330]store the properties of MessageBatch

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on a change in pull request #2343:
URL: https://github.com/apache/rocketmq/pull/2343#discussion_r502851898



##########
File path: broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java
##########
@@ -577,6 +577,7 @@ private RemotingCommand handlePutMessageResult(PutMessageResult putMessageResult
         messageExtBatch.setFlag(requestHeader.getFlag());
         MessageAccessor.setProperties(messageExtBatch, MessageDecoder.string2messageProperties(requestHeader.getProperties()));
         messageExtBatch.setBody(request.getBody());
+        messageExtBatch.setPropertiesString(requestHeader.getProperties());

Review comment:
       IMO, set properties has been done in this code `MessageAccessor.setProperties(messageExtBatch, MessageDecoder.string2messageProperties(requestHeader.getProperties()));`, so we don't need add a new variable named propertiesString to MessageExtBatch to do this thing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org