You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/21 18:29:14 UTC

[GitHub] [superset] ktmud commented on pull request #17176: fix(AlertReportModal): Text Area Change

ktmud commented on pull request #17176:
URL: https://github.com/apache/superset/pull/17176#issuecomment-948892722


   In general it's preferable to always add debounce to text inputs because even if they don't trigger remote API calls, they could still trigger expensive re-rendering. Not sure if this will work, but an alternative solution here could be to re-render the modal completely when users go to a new report, which can probably be achieved by setting a uniq `key` to [the `TextAreaControl` component](https://github.com/apache/superset/blob/9b17e86b447dc36fd39c3912d3ed3baf78d3bb2e/superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx#L1124-L1133).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org