You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/05/18 12:31:37 UTC

[GitHub] [incubator-iotdb] JulianFeinauer commented on a change in pull request #1224: [IoTDB-531]fix issue when grafana visualize boolean data.

JulianFeinauer commented on a change in pull request #1224:
URL: https://github.com/apache/incubator-iotdb/pull/1224#discussion_r426589846



##########
File path: distribution/src/assembly/distribution.xml
##########
@@ -34,6 +34,14 @@
             <outputDirectory>${file.separator}</outputDirectory>
             <unpack>true</unpack>
         </dependencySet>
+        <dependencySet>
+            <includes>
+                <include>*:iotdb-grafana:*</include>
+            </includes>
+            <outputDirectory>tools/grafana/</outputDirectory>
+            <outputFileNameMapping>${artifact.artifactId}.${artifact.extension}</outputFileNameMapping>
+            <unpack>false</unpack>

Review comment:
       should we also include the config here? This is something I forgot in 0.9.3 branch. WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org