You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/15 09:36:42 UTC

[GitHub] [flink] tillrohrmann commented on a change in pull request #11746: [FLINK-16750][e2e] Always copy and show the logs when yarn e2e tests failed

tillrohrmann commented on a change in pull request #11746: [FLINK-16750][e2e] Always copy and show the logs when yarn e2e tests failed
URL: https://github.com/apache/flink/pull/11746#discussion_r408710249
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/common_yarn_docker.sh
 ##########
 @@ -29,6 +29,8 @@ MAX_RETRY_SECONDS=120
 CLUSTER_SETUP_RETRIES=3
 IMAGE_BUILD_RETRIES=5
 
+SUCCEEDED=1
 
 Review comment:
   Instead of introducing this custom variable, would it make sense to let `_on_exit_callback` in `common_utils.sh` export the `$?` so that the on exit actions have access to it? That way the mechanism would be simpler since the user of this script does not have to remember to set `SUCCEEDED` to 0 if everything was ok.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services