You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by richard zhou <ri...@intel.com> on 2015/07/09 10:48:10 UTC
Re: Review Request 35377: SQOOP-2398: Show all job with order
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35377/
-----------------------------------------------------------
(Updated July 9, 2015, 8:48 a.m.)
Review request for Sqoop.
Changes
-------
Add the test
Repository: sqoop-sqoop2
Description
-------
Show all job with order
Diffs (updated)
-----
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java c8335c0a1cefb1d6f2e95f3901546cd63559c3f7
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 932557fd9cd7ee8ee075ab517df51475c4498aec
test/src/test/java/org/apache/sqoop/integration/server/ShowJobInOrderTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/35377/diff/
Testing
-------
local
Thanks,
richard zhou
Re: Review Request 35377: SQOOP-2398: Show all job with order
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35377/#review91079
-----------------------------------------------------------
Ship it!
Seems cool. Might be nice to add filters and sorting to the Rest API in the future as well.
test/src/test/java/org/apache/sqoop/integration/server/ShowJobInOrderTest.java (line 28)
<https://reviews.apache.org/r/35377/#comment144348>
Use testng version?
- Abraham Elmahrek
On July 9, 2015, 8:48 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35377/
> -----------------------------------------------------------
>
> (Updated July 9, 2015, 8:48 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Show all job with order
>
>
> Diffs
> -----
>
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java c8335c0a1cefb1d6f2e95f3901546cd63559c3f7
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 932557fd9cd7ee8ee075ab517df51475c4498aec
> test/src/test/java/org/apache/sqoop/integration/server/ShowJobInOrderTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35377/diff/
>
>
> Testing
> -------
>
> local
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 35377: SQOOP-2398: Show all job with order
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35377/#review91304
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On July 10, 2015, 3:28 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35377/
> -----------------------------------------------------------
>
> (Updated July 10, 2015, 3:28 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Show all job with order
>
>
> Diffs
> -----
>
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java c8335c0a1cefb1d6f2e95f3901546cd63559c3f7
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 932557fd9cd7ee8ee075ab517df51475c4498aec
> test/src/test/java/org/apache/sqoop/integration/server/ShowJobInOrderTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35377/diff/
>
>
> Testing
> -------
>
> local
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 35377: SQOOP-2398: Show all job with order
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35377/
-----------------------------------------------------------
(Updated July 10, 2015, 3:28 a.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
Show all job with order
Diffs (updated)
-----
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java c8335c0a1cefb1d6f2e95f3901546cd63559c3f7
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 932557fd9cd7ee8ee075ab517df51475c4498aec
test/src/test/java/org/apache/sqoop/integration/server/ShowJobInOrderTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/35377/diff/
Testing
-------
local
Thanks,
richard zhou