You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2019/05/07 15:30:02 UTC

Review Request 70604: RANGER-2415: Value of isExcludes flag needs to be considered when matching accessed resource to Ranger policy

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70604/
-----------------------------------------------------------

Review request for ranger, Bolke de Bruin, Madhan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-2415
    https://issues.apache.org/jira/browse/RANGER-2415


Repository: ranger


Description
-------

Access evaluation compares Ranger policies against accessed resource using a Policy-Resource matching algorithm. It needs to always take into consideration value of isExcludes flag specified for each resource-level when comparing resource values in the resource hierarchy.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java b0fcf6e33 
  agents-common/src/test/resources/resourcematcher/test_defaultpolicyresourcematcher.json 68166f950 


Diff: https://reviews.apache.org/r/70604/diff/1/


Testing
-------

Developed and ran unit tests containing policy-resources with isExcludes flag set to true and false. Ensured the matching algorithm works correctly when isExcludes flag for any resource in the hierarchy is set to true.


Thanks,

Abhay Kulkarni


Re: Review Request 70604: RANGER-2415: Value of isExcludes flag needs to be considered when matching accessed resource to Ranger policy

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70604/#review215096
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On May 7, 2019, 3:30 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70604/
> -----------------------------------------------------------
> 
> (Updated May 7, 2019, 3:30 p.m.)
> 
> 
> Review request for ranger, Bolke de Bruin, Madhan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2415
>     https://issues.apache.org/jira/browse/RANGER-2415
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Access evaluation compares Ranger policies against accessed resource using a Policy-Resource matching algorithm. It needs to always take into consideration value of isExcludes flag specified for each resource-level when comparing resource values in the resource hierarchy.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java b0fcf6e33 
>   agents-common/src/test/resources/resourcematcher/test_defaultpolicyresourcematcher.json 68166f950 
> 
> 
> Diff: https://reviews.apache.org/r/70604/diff/1/
> 
> 
> Testing
> -------
> 
> Developed and ran unit tests containing policy-resources with isExcludes flag set to true and false. Ensured the matching algorithm works correctly when isExcludes flag for any resource in the hierarchy is set to true.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>