You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Sean Owen (JIRA)" <ji...@apache.org> on 2019/03/17 00:46:00 UTC

[jira] [Assigned] (SPARK-26941) incorrect computation of maxNumExecutorFailures in ApplicationMaster for streaming

     [ https://issues.apache.org/jira/browse/SPARK-26941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Owen reassigned SPARK-26941:
---------------------------------

    Assignee: liupengcheng

> incorrect computation of maxNumExecutorFailures in ApplicationMaster for streaming 
> -----------------------------------------------------------------------------------
>
>                 Key: SPARK-26941
>                 URL: https://issues.apache.org/jira/browse/SPARK-26941
>             Project: Spark
>          Issue Type: Bug
>          Components: Spark Core, YARN
>    Affects Versions: 2.1.0, 2.4.0
>            Reporter: liupengcheng
>            Assignee: liupengcheng
>            Priority: Major
>
> Currently, when enabled streaming dynamic allocation for streaming applications, the maxNumExecutorFailures in ApplicationMaster is still computed with `spark.dynamicAllocation.maxExecutors`. 
> Actually, we should consider `spark.streaming.dynamicAllocation.maxExecutors` instead.
> Related codes:
> {code:java}
> private val maxNumExecutorFailures = {
>   val effectiveNumExecutors =
>     if (Utils.isStreamingDynamicAllocationEnabled(sparkConf)) {
>       sparkConf.get(STREAMING_DYN_ALLOCATION_MAX_EXECUTORS)
>     } else if (Utils.isDynamicAllocationEnabled(sparkConf)) {
>       sparkConf.get(DYN_ALLOCATION_MAX_EXECUTORS)
>     } else {
>       sparkConf.get(EXECUTOR_INSTANCES).getOrElse(0)
>     }
>   // By default, effectiveNumExecutors is Int.MaxValue if dynamic allocation is enabled. We need
>   // avoid the integer overflow here.
>   val defaultMaxNumExecutorFailures = math.max(3,
>     if (effectiveNumExecutors > Int.MaxValue / 2) Int.MaxValue else (2 * effectiveNumExecutors))
>   sparkConf.get(MAX_EXECUTOR_FAILURES).getOrElse(defaultMaxNumExecutorFailures)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org