You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "gbloisi-openaire (via GitHub)" <gi...@apache.org> on 2023/08/04 19:43:43 UTC

[GitHub] [spark] gbloisi-openaire commented on a diff in pull request #42327: [SPARK-44634][SQL] Encoders.bean does no longer support nested beans with type arguments

gbloisi-openaire commented on code in PR #42327:
URL: https://github.com/apache/spark/pull/42327#discussion_r1284792298


##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala:
##########


Review Comment:
   Sure. Thanks for pointing that, I just committed the change. I didn't realize the change could be easily reused for lists and maps, reducing the code a lot.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org