You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@continuum.apache.org by ev...@apache.org on 2005/11/15 17:48:41 UTC

svn commit: r344392 - /maven/continuum/trunk/continuum-store/src/main/java/org/apache/maven/continuum/store/JdoContinuumStore.java

Author: evenisse
Date: Tue Nov 15 08:48:36 2005
New Revision: 344392

URL: http://svn.apache.org/viewcvs?rev=344392&view=rev
Log:
Retry the update if derby generate a lock exception

Modified:
    maven/continuum/trunk/continuum-store/src/main/java/org/apache/maven/continuum/store/JdoContinuumStore.java

Modified: maven/continuum/trunk/continuum-store/src/main/java/org/apache/maven/continuum/store/JdoContinuumStore.java
URL: http://svn.apache.org/viewcvs/maven/continuum/trunk/continuum-store/src/main/java/org/apache/maven/continuum/store/JdoContinuumStore.java?rev=344392&r1=344391&r2=344392&view=diff
==============================================================================
--- maven/continuum/trunk/continuum-store/src/main/java/org/apache/maven/continuum/store/JdoContinuumStore.java (original)
+++ maven/continuum/trunk/continuum-store/src/main/java/org/apache/maven/continuum/store/JdoContinuumStore.java Tue Nov 15 08:48:36 2005
@@ -472,7 +472,15 @@
                 throw new ContinuumStoreException( "Not detached: " + object );
             }
 
-            pm.attachCopy( object, true );
+            try
+            {
+                pm.attachCopy( object, true );
+            }
+            catch ( Exception e )
+            {
+                //We retry if we obtain an exceptio like a dead lock
+                pm.attachCopy( object, true );
+            }
 
             tx.commit();
         }



Re: svn commit: r344392 - /maven/continuum/trunk/continuum-store/src/main/java/org/apache/maven/continuum/store/JdoContinuumStore.java

Posted by Brett Porter <br...@apache.org>.
Is this stil lrequired after the other fix?

If so, can we be more specific about the caught exception?

evenisse@apache.org wrote:
> Author: evenisse
> Date: Tue Nov 15 08:48:36 2005
> New Revision: 344392
> 
> URL: http://svn.apache.org/viewcvs?rev=344392&view=rev
> Log:
> Retry the update if derby generate a lock exception
> 
> Modified:
>     maven/continuum/trunk/continuum-store/src/main/java/org/apache/maven/continuum/store/JdoContinuumStore.java
> 
> Modified: maven/continuum/trunk/continuum-store/src/main/java/org/apache/maven/continuum/store/JdoContinuumStore.java
> URL: http://svn.apache.org/viewcvs/maven/continuum/trunk/continuum-store/src/main/java/org/apache/maven/continuum/store/JdoContinuumStore.java?rev=344392&r1=344391&r2=344392&view=diff
> ==============================================================================
> --- maven/continuum/trunk/continuum-store/src/main/java/org/apache/maven/continuum/store/JdoContinuumStore.java (original)
> +++ maven/continuum/trunk/continuum-store/src/main/java/org/apache/maven/continuum/store/JdoContinuumStore.java Tue Nov 15 08:48:36 2005
> @@ -472,7 +472,15 @@
>                  throw new ContinuumStoreException( "Not detached: " + object );
>              }
>  
> -            pm.attachCopy( object, true );
> +            try
> +            {
> +                pm.attachCopy( object, true );
> +            }
> +            catch ( Exception e )
> +            {
> +                //We retry if we obtain an exceptio like a dead lock
> +                pm.attachCopy( object, true );
> +            }
>  
>              tx.commit();
>          }
> 
>