[GitHub] [trafficcontrol] rimashah25 commented on a change in pull request #5495: Ability to change the name of a topology

[GitBox <gi...@apache.org>]

rimashah25 commented on a change in pull request #5495:
URL: https://github.com/apache/trafficcontrol/pull/5495#discussion_r570576736



##########
File path: traffic_ops/traffic_ops_golang/topology/topologies.go
##########
@@ -394,8 +394,10 @@ func (topology TOTopology) GetKeys() (map[string]interface{}, bool) {
 
 // SetKeys is a requirement of the api.Updater interface and is called by
 // api.UpdateHandler().
+// SetKeys function will no longer makes the name key immutable by setting it to
+// query param. On 2/3/21, the requirement was added to change the topology name.
 func (topology *TOTopology) SetKeys(keys map[string]interface{}) {
-	topology.Name, _ = keys["name"].(string)
+	//topology.Name, _ = keys["name"].(string)

Review comment:
       Good catch.. I updated the Validate()




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org