You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/07 11:42:28 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #12326: Fixes control panel fields styling (#12236)
michael-s-molina opened a new pull request #12326:
URL: https://github.com/apache/superset/pull/12326
### SUMMARY
Adjusted METRICS and FILTER to use 4px border radius
Adjusted GROUP BY to keep same margin as METRICS and FILTERS
Adjusted RATIO height, border and box shadow
Adjusted METRICS, FILTERS and GROUP BY border colors
Adjusted search height and box shadow
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="624" alt="Screen Shot 2021-01-07 at 8 31 49 AM" src="https://user-images.githubusercontent.com/70410625/103888108-ec1af800-50c2-11eb-84d1-71c01cadb629.png">
<img width="623" alt="Screen Shot 2021-01-07 at 8 25 25 AM" src="https://user-images.githubusercontent.com/70410625/103888126-f210d900-50c2-11eb-9fe0-b8f9118a7cb7.png">
#12236
@junlincc
### TEST PLAN
1 - Select a chart
2 - View changes in control panel
3 - Repeat this process for charts with different control panel fields
### ADDITIONAL INFORMATION
- [x] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756949662
@junlincc I made all the requested changes.
<img width="373" alt="Screen Shot 2021-01-08 at 4 22 08 PM" src="https://user-images.githubusercontent.com/70410625/104055586-c9c1d100-51cd-11eb-8d6a-648189c9a4f4.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-757064583
> @junlincc I made all the requested changes.
I'm not able to see the latest changes(tried different browsers) when I tested. @michael-s-molina
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756115362
> Could you verify as well situation when we try to click on
> 
> And then try to expand dropdowns:
>
> dropdown.mov
@adam-stasiak I just confirmed that this is happening in master. Can you open a new issue and remove this comment so we can keep only related issues?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756949662
@junlincc I made all the requested changes.
<img width="373" alt="Screen Shot 2021-01-08 at 4 22 08 PM" src="https://user-images.githubusercontent.com/70410625/104055586-c9c1d100-51cd-11eb-8d6a-648189c9a4f4.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
# [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=h1) Report
> Merging [#12326](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=desc) (ef180ce) into [master](https://codecov.io/gh/apache/superset/commit/64b49778c5a1fedfaa16b056af0f76f38556d292?el=desc) (64b4977) will **increase** coverage by `0.64%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12326 +/- ##
==========================================
+ Coverage 66.15% 66.79% +0.64%
==========================================
Files 1014 1014
Lines 49510 49531 +21
Branches 5063 5072 +9
==========================================
+ Hits 32753 33086 +333
+ Misses 16607 16311 -296
+ Partials 150 134 -16
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.55% <100.00%> (+5.52%)` | :arrow_up: |
| javascript | `60.70% <70.58%> (+<0.01%)` | :arrow_up: |
| python | `64.21% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `69.04% <ø> (+23.80%)` | :arrow_up: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `85.71% <90.90%> (-0.59%)` | :arrow_down: |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `90.47% <100.00%> (-0.23%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `80.12% <100.00%> (+0.12%)` | :arrow_up: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `76.19% <100.00%> (+0.58%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-7.60%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.58% <0.00%> (-5.07%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `58.11% <0.00%> (-3.64%)` | :arrow_down: |
| ... and [66 more](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=footer). Last update [64b4977...ef180ce](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
pkdotson commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-758222015
rolling window will be fixed in this upcoming pr: https://github.com/apache-superset/superset-ui/pull/895
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756269876
scope of the issue/pr should be limited to styling changes. which are done!
@pkdotson and @mihir174 will open a separate PR to address the layout issue. 🙏 thanks all!
<img width="298" alt="Screen Shot 2021-01-07 at 9 30 34 AM" src="https://user-images.githubusercontent.com/67837651/103924686-3bfdbd00-50cb-11eb-8471-397aa324dab5.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756145975
LGTM, thank you for your fix.
@michael-s-molina @junlincc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756143096
> same style problem at the latest master branch. so we need new PR fix this issue.
>
> <img alt="image" width="1257" src="https://user-images.githubusercontent.com/2016594/103902309-49e82800-5135-11eb-9ca2-d98808e0e7d7.png">
@zhaoyongjie No problem. I'll fix this issue in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
# [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=h1) Report
> Merging [#12326](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=desc) (ef180ce) into [master](https://codecov.io/gh/apache/superset/commit/64b49778c5a1fedfaa16b056af0f76f38556d292?el=desc) (64b4977) will **decrease** coverage by `3.53%`.
> The diff coverage is `70.58%`.
[](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12326 +/- ##
==========================================
- Coverage 66.15% 62.61% -3.54%
==========================================
Files 1014 1014
Lines 49510 49517 +7
Branches 5063 5072 +9
==========================================
- Hits 32753 31005 -1748
- Misses 16607 18303 +1696
- Partials 150 209 +59
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.70% <70.58%> (+<0.01%)` | :arrow_up: |
| python | `63.86% <ø> (-0.35%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `2.56% <0.00%> (-77.44%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `42.85% <ø> (-2.39%)` | :arrow_down: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `62.33% <72.72%> (-23.97%)` | :arrow_down: |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `85.71% <100.00%> (-4.99%)` | :arrow_down: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `42.85% <100.00%> (-32.76%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [165 more](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=footer). Last update [64b4977...ef180ce](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
# [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=h1) Report
> Merging [#12326](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=desc) (6d29c02) into [master](https://codecov.io/gh/apache/superset/commit/f48284909dde84d13276bb40ddd91ec6935f10e5?el=desc) (f482849) will **decrease** coverage by `4.26%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12326 +/- ##
==========================================
- Coverage 67.15% 62.89% -4.27%
==========================================
Files 1002 1002
Lines 49324 49313 -11
Branches 5020 5020
==========================================
- Hits 33124 31015 -2109
- Misses 16075 18094 +2019
- Partials 125 204 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.17% <50.00%> (+<0.01%)` | :arrow_up: |
| python | `64.01% <ø> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `85.36% <ø> (-4.88%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `2.59% <0.00%> (-77.28%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `42.85% <ø> (-26.20%)` | :arrow_down: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `63.88% <50.00%> (-23.62%)` | :arrow_down: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `42.85% <100.00%> (-32.76%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [197 more](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=footer). Last update [f482849...6d29c02](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
# [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=h1) Report
> Merging [#12326](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=desc) (8f0aa0b) into [master](https://codecov.io/gh/apache/superset/commit/2b6a58780a8e29b8e9a054118b4776ea25ad1f6e?el=desc) (2b6a587) will **decrease** coverage by `11.95%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12326 +/- ##
===========================================
- Coverage 63.00% 51.05% -11.96%
===========================================
Files 1002 466 -536
Lines 49268 16805 -32463
Branches 5003 4321 -682
===========================================
- Hits 31039 8579 -22460
+ Misses 18028 8226 -9802
+ Partials 201 0 -201
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.05% <100.00%> (?)` | |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `88.23% <ø> (+10.96%)` | :arrow_up: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `73.68% <ø> (+32.22%)` | :arrow_up: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `66.66% <ø> (+23.80%)` | :arrow_up: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `93.75% <100.00%> (+29.86%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [918 more](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=footer). Last update [2b6a587...8f0aa0b](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756143096
> same style problem at the latest master branch. so we need new PR fix thit issue.
>
> <img alt="image" width="1257" src="https://user-images.githubusercontent.com/2016594/103902309-49e82800-5135-11eb-9ca2-d98808e0e7d7.png">
@zhaoyongjie No problem. I'll fix this issue in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #12326:
URL: https://github.com/apache/superset/pull/12326#discussion_r553566401
##########
File path: superset-frontend/stylesheets/less/cosmo/variables.less
##########
@@ -91,7 +91,7 @@
//
// ## Define common padding and border radius sizes and more. Values based on 14px text and 1.428 line-height (~20px to start).
-@padding-base-vertical: 10px;
+@padding-base-vertical: 6.5px;
Review comment:
Since this is part of the broader bootstrap theme, I'm a little worried this might cause some other regression somewhere else in the application. Have you done some kind of visual audit, or could we make this change in the relevant component(s) with Emotion styling?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
# [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=h1) Report
> Merging [#12326](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=desc) (ef180ce) into [master](https://codecov.io/gh/apache/superset/commit/64b49778c5a1fedfaa16b056af0f76f38556d292?el=desc) (64b4977) will **decrease** coverage by `3.66%`.
> The diff coverage is `70.58%`.
[](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12326 +/- ##
==========================================
- Coverage 66.15% 62.48% -3.67%
==========================================
Files 1014 1014
Lines 49510 49517 +7
Branches 5063 5072 +9
==========================================
- Hits 32753 30941 -1812
- Misses 16607 18367 +1760
- Partials 150 209 +59
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.70% <70.58%> (+<0.01%)` | :arrow_up: |
| python | `63.65% <ø> (-0.56%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `2.56% <0.00%> (-77.44%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `42.85% <ø> (-2.39%)` | :arrow_down: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `62.33% <72.72%> (-23.97%)` | :arrow_down: |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `85.71% <100.00%> (-4.99%)` | :arrow_down: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `42.85% <100.00%> (-32.76%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [170 more](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=footer). Last update [64b4977...ef180ce](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
# [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=h1) Report
> Merging [#12326](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=desc) (ef180ce) into [master](https://codecov.io/gh/apache/superset/commit/64b49778c5a1fedfaa16b056af0f76f38556d292?el=desc) (64b4977) will **decrease** coverage by `3.32%`.
> The diff coverage is `70.58%`.
[](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12326 +/- ##
==========================================
- Coverage 66.15% 62.82% -3.33%
==========================================
Files 1014 1014
Lines 49510 49517 +7
Branches 5063 5072 +9
==========================================
- Hits 32753 31110 -1643
- Misses 16607 18198 +1591
- Partials 150 209 +59
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.70% <70.58%> (+<0.01%)` | :arrow_up: |
| python | `64.21% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `2.56% <0.00%> (-77.44%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `42.85% <ø> (-2.39%)` | :arrow_down: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `62.33% <72.72%> (-23.97%)` | :arrow_down: |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `85.71% <100.00%> (-4.99%)` | :arrow_down: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `42.85% <100.00%> (-32.76%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [163 more](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=footer). Last update [64b4977...ef180ce](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756140662
same style problem at the latest master branch. so we need new PR fix thit issue.
<img width="1257" alt="image" src="https://user-images.githubusercontent.com/2016594/103902309-49e82800-5135-11eb-9ca2-d98808e0e7d7.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-758315693
<img width="2045" alt="Screen Shot 2021-01-11 at 4 28 20 PM" src="https://user-images.githubusercontent.com/67837651/104254289-5d440d80-542b-11eb-81fc-8b1d414ed6ee.png">
<img width="2046" alt="Screen Shot 2021-01-11 at 4 36 36 PM" src="https://user-images.githubusercontent.com/67837651/104254296-603efe00-542b-11eb-9fc1-91fe64e18722.png">
while we tested again, we found blank page of deck.glMultiple Layers. and confirm that this has been an issue, not related to this PR.
This PR is good to go if codes look ok!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic commented on a change in pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
nikolagigic commented on a change in pull request #12326:
URL: https://github.com/apache/superset/pull/12326#discussion_r553373600
##########
File path: superset-frontend/src/explore/components/OptionControls.tsx
##########
@@ -84,7 +84,7 @@ export const HeaderContainer = styled.div`
export const LabelsContainer = styled.div`
padding: ${({ theme }) => theme.gridUnit}px;
border: solid 1px ${({ theme }) => theme.colors.grayscale.light2};
- border-radius: 3px;
+ border-radius: 4px;
Review comment:
Could we maybe use `gridUnit` here as well? As it will have the same result but keep it consistent with the rest of the styling?
```suggestion
border-radius: ${({ theme }) => theme.gridUnit}px;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756145928
> thank you @adam-stasiak for spotting the issue!
> if the code looks good and we can confirm the styling issue preexists. let's merge this PR.
We can't merge it just yet. Although this is problem exists in master, some inputs became bigger and when we hover them we have some layout problems. I'm fixing this right now and I'll also fix the preexisting problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
# [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=h1) Report
> Merging [#12326](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=desc) (ef180ce) into [master](https://codecov.io/gh/apache/superset/commit/64b49778c5a1fedfaa16b056af0f76f38556d292?el=desc) (64b4977) will **increase** coverage by `0.73%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12326 +/- ##
==========================================
+ Coverage 66.15% 66.88% +0.73%
==========================================
Files 1014 1014
Lines 49510 49531 +21
Branches 5063 5072 +9
==========================================
+ Hits 32753 33129 +376
+ Misses 16607 16272 -335
+ Partials 150 130 -20
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.93% <100.00%> (+5.90%)` | :arrow_up: |
| javascript | `60.70% <70.58%> (+<0.01%)` | :arrow_up: |
| python | `64.21% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `69.04% <ø> (+23.80%)` | :arrow_up: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `85.71% <90.90%> (-0.59%)` | :arrow_down: |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `90.47% <100.00%> (-0.23%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `80.12% <100.00%> (+0.12%)` | :arrow_up: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `76.19% <100.00%> (+0.58%)` | :arrow_up: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `74.60% <0.00%> (-1.21%)` | :arrow_down: |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `50.00% <0.00%> (-1.03%)` | :arrow_down: |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `83.33% <0.00%> (ø)` | |
| [...-frontend/src/explore/components/RowCountLabel.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Sb3dDb3VudExhYmVsLmpzeA==) | `100.00% <0.00%> (ø)` | |
| ... and [63 more](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=footer). Last update [64b4977...ef180ce](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756144213
thank you @adam-stasiak for spotting the issue!
if the code looks good and we can confirm the styling issue preexists. let's merge this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-757064583
> @junlincc I made all the requested changes.
I'm not able to see the latest changes(tried different browsers) when I tested. @michael-s-molina
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
# [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=h1) Report
> Merging [#12326](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=desc) (ef180ce) into [master](https://codecov.io/gh/apache/superset/commit/64b49778c5a1fedfaa16b056af0f76f38556d292?el=desc) (64b4977) will **decrease** coverage by `2.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12326 +/- ##
==========================================
- Coverage 66.15% 63.60% -2.55%
==========================================
Files 1014 485 -529
Lines 49510 29873 -19637
Branches 5063 0 -5063
==========================================
- Hits 32753 19002 -13751
+ Misses 16607 10871 -5736
+ Partials 150 0 -150
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.60% <ø> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.13%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [530 more](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=footer). Last update [64b4977...ef180ce](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc removed a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-757064583
> @junlincc I made all the requested changes.
I'm not able to see the latest changes(tried different browsers) when I tested. @michael-s-molina
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak removed a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
adam-stasiak removed a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756105071
Could you verify as well situation when we try to click on
And then try to expand dropdowns:
https://user-images.githubusercontent.com/25153919/103895931-7712e700-50f1-11eb-8f80-11f70a90c4ce.mov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
# [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=h1) Report
> Merging [#12326](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=desc) (8f0aa0b) into [master](https://codecov.io/gh/apache/superset/commit/2b6a58780a8e29b8e9a054118b4776ea25ad1f6e?el=desc) (2b6a587) will **decrease** coverage by `11.50%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12326 +/- ##
===========================================
- Coverage 63.00% 51.49% -11.51%
===========================================
Files 1002 466 -536
Lines 49268 16805 -32463
Branches 5003 4321 -682
===========================================
- Hits 31039 8654 -22385
+ Misses 18028 8151 -9877
+ Partials 201 0 -201
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.49% <100.00%> (?)` | |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `88.23% <ø> (+10.96%)` | :arrow_up: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `73.68% <ø> (+32.22%)` | :arrow_up: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `66.66% <ø> (+23.80%)` | :arrow_up: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `93.75% <100.00%> (+29.86%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [918 more](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=footer). Last update [2b6a587...8f0aa0b](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
# [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=h1) Report
> Merging [#12326](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=desc) (ef180ce) into [master](https://codecov.io/gh/apache/superset/commit/64b49778c5a1fedfaa16b056af0f76f38556d292?el=desc) (64b4977) will **decrease** coverage by `2.50%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12326 +/- ##
==========================================
- Coverage 66.15% 63.65% -2.50%
==========================================
Files 1014 485 -529
Lines 49510 29888 -19622
Branches 5063 0 -5063
==========================================
- Hits 32753 19025 -13728
+ Misses 16607 10863 -5744
+ Partials 150 0 -150
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.65% <ø> (-0.56%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.13%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | | |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | | |
| ... and [521 more](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=footer). Last update [64b4977...ef180ce](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
# [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=h1) Report
> Merging [#12326](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=desc) (6d29c02) into [master](https://codecov.io/gh/apache/superset/commit/f48284909dde84d13276bb40ddd91ec6935f10e5?el=desc) (f482849) will **decrease** coverage by `4.72%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12326 +/- ##
==========================================
- Coverage 67.15% 62.42% -4.73%
==========================================
Files 1002 1002
Lines 49324 49298 -26
Branches 5020 5020
==========================================
- Hits 33124 30776 -2348
- Misses 16075 18318 +2243
- Partials 125 204 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.17% <50.00%> (+<0.01%)` | :arrow_up: |
| python | `63.24% <ø> (-0.92%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `85.36% <ø> (-4.88%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `2.59% <0.00%> (-77.28%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `42.85% <ø> (-26.20%)` | :arrow_down: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `63.88% <50.00%> (-23.62%)` | :arrow_down: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `42.85% <100.00%> (-32.76%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [223 more](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=footer). Last update [f482849...6d29c02](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756099258
My scenario:
Built everything with command:
```CYPRESS_CONFIG=true docker-compose up```
Then opened chart:
Then expanded advanced analytics
I observed Rolling Function glitch:
I compared this to version from different branch:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
# [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=h1) Report
> Merging [#12326](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=desc) (ef180ce) into [master](https://codecov.io/gh/apache/superset/commit/4cf3f99ee881a10995212828494f0b126dd5415e?el=desc) (4cf3f99) will **increase** coverage by `0.09%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12326 +/- ##
==========================================
+ Coverage 66.79% 66.88% +0.09%
==========================================
Files 1014 1014
Lines 49524 49531 +7
Branches 5077 5072 -5
==========================================
+ Hits 33079 33129 +50
+ Misses 16314 16272 -42
+ Partials 131 130 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.93% <100.00%> (-0.04%)` | :arrow_down: |
| javascript | `60.70% <70.58%> (-0.01%)` | :arrow_down: |
| python | `64.21% <ø> (+0.15%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `69.04% <ø> (ø)` | |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `85.71% <90.90%> (-0.40%)` | :arrow_down: |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `90.47% <100.00%> (-0.23%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `80.12% <100.00%> (-0.13%)` | :arrow_down: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `76.19% <100.00%> (+0.58%)` | :arrow_up: |
| [...dashboard/components/FiltersBadge/DetailsPanel.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwudHN4) | `54.54% <0.00%> (-2.60%)` | :arrow_down: |
| [superset/examples/helpers.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | `95.12% <0.00%> (-2.44%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SaveQuery.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVRdWVyeS50c3g=) | `72.72% <0.00%> (-1.70%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `48.78% <0.00%> (-1.22%)` | :arrow_down: |
| ... and [56 more](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=footer). Last update [4cf3f99...58bc312](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756262185
@nikolagigic Accepted all your suggestions. Thanks.
I increased the width (320px to 380px) of both panels to support bigger inputs. We still have the situation of layout flicks when we hover elements because there is no space available for the tooltip icon and this creates a line break. In talks with @junlincc she told me that this is being fixed in another PR where we're going to stack all controls and this line break problem won't happen anymore. So I will limit the scope of this PR to just fixing input styles.
For documentation purposes these images bellow show some examples where a line break happens:
<img width="782" alt="Screen Shot 2021-01-07 at 2 22 30 PM" src="https://user-images.githubusercontent.com/70410625/103923664-205adc80-50f4-11eb-8463-afce92ac7e2d.png">
<img width="777" alt="Screen Shot 2021-01-07 at 2 27 00 PM" src="https://user-images.githubusercontent.com/70410625/103924186-77f94800-50f4-11eb-8b1a-2e9611b130a4.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
# [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=h1) Report
> Merging [#12326](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=desc) (6d29c02) into [master](https://codecov.io/gh/apache/superset/commit/f48284909dde84d13276bb40ddd91ec6935f10e5?el=desc) (f482849) will **decrease** coverage by `4.16%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12326 +/- ##
==========================================
- Coverage 67.15% 62.98% -4.17%
==========================================
Files 1002 1002
Lines 49324 49313 -11
Branches 5020 5020
==========================================
- Hits 33124 31061 -2063
- Misses 16075 18048 +1973
- Partials 125 204 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.17% <50.00%> (+<0.01%)` | :arrow_up: |
| python | `64.16% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `85.36% <ø> (-4.88%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `2.59% <0.00%> (-77.28%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `42.85% <ø> (-26.20%)` | :arrow_down: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `63.88% <50.00%> (-23.62%)` | :arrow_down: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `42.85% <100.00%> (-32.76%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [193 more](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=footer). Last update [f482849...6d29c02](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756116414
> > Could you verify as well situation when we try to click on
> > 
> > And then try to expand dropdowns:
> > dropdown.mov
>
> @adam-stasiak I just confirmed that this is happening in master. Can you open a new issue and remove this comment so we can keep only related issues?
Yes sure :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic commented on a change in pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
nikolagigic commented on a change in pull request #12326:
URL: https://github.com/apache/superset/pull/12326#discussion_r553373751
##########
File path: superset-frontend/src/explore/components/OptionControls.tsx
##########
@@ -96,7 +96,7 @@ export const AddControlLabel = styled.div`
font-size: ${({ theme }) => theme.typography.sizes.s}px;
color: ${({ theme }) => theme.colors.grayscale.light1};
border: dashed 1px ${({ theme }) => theme.colors.grayscale.light2};
- border-radius: 3px;
+ border-radius: 4px;
Review comment:
Same here ^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756144213
agreed, thank you @adam-stasiak for spotting the issue!
if the code looks good and we can confirm the styling issue preexists. let's merge this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
# [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=h1) Report
> Merging [#12326](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=desc) (ef180ce) into [master](https://codecov.io/gh/apache/superset/commit/64b49778c5a1fedfaa16b056af0f76f38556d292?el=desc) (64b4977) will **decrease** coverage by `2.86%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12326 +/- ##
==========================================
- Coverage 66.15% 63.29% -2.87%
==========================================
Files 1014 485 -529
Lines 49510 29873 -19637
Branches 5063 0 -5063
==========================================
- Hits 32753 18907 -13846
+ Misses 16607 10966 -5641
+ Partials 150 0 -150
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.29% <ø> (-0.92%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.13%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `86.49% <0.00%> (-5.49%)` | :arrow_down: |
| ... and [545 more](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=footer). Last update [64b4977...ef180ce](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #12326:
URL: https://github.com/apache/superset/pull/12326#discussion_r553567080
##########
File path: superset-frontend/stylesheets/less/variables.less
##########
@@ -47,7 +47,7 @@
@almost-black: #263238;
@gray-dark: #484848;
-@gray-light: #cfd8dc;
+@gray-light: #e0e0e0;
Review comment:
Actually that was the intention because `#e0e0e0` is the official gray-light theme color.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756105071
Could you verify as well situation when we try to click on
And then try to expand dropdowns:
https://user-images.githubusercontent.com/25153919/103895931-7712e700-50f1-11eb-8f80-11f70a90c4ce.mov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
# [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=h1) Report
> Merging [#12326](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=desc) (6d29c02) into [master](https://codecov.io/gh/apache/superset/commit/f48284909dde84d13276bb40ddd91ec6935f10e5?el=desc) (f482849) will **decrease** coverage by `4.53%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12326 +/- ##
==========================================
- Coverage 67.15% 62.62% -4.54%
==========================================
Files 1002 1002
Lines 49324 49298 -26
Branches 5020 5020
==========================================
- Hits 33124 30873 -2251
- Misses 16075 18221 +2146
- Partials 125 204 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.17% <50.00%> (+<0.01%)` | :arrow_up: |
| python | `63.56% <ø> (-0.59%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `85.36% <ø> (-4.88%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `2.59% <0.00%> (-77.28%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `42.85% <ø> (-26.20%)` | :arrow_down: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `63.88% <50.00%> (-23.62%)` | :arrow_down: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `42.85% <100.00%> (-32.76%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [210 more](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=footer). Last update [f482849...6d29c02](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #12326:
URL: https://github.com/apache/superset/pull/12326#discussion_r553565907
##########
File path: superset-frontend/stylesheets/less/variables.less
##########
@@ -47,7 +47,7 @@
@almost-black: #263238;
@gray-dark: #484848;
-@gray-light: #cfd8dc;
+@gray-light: #e0e0e0;
Review comment:
This is going to affect (apparently) at least 68 other things in the codebase. Is this a situation where we could use Emotion's `styled` to apply this color in a more specific place (using `theme.colors.grayscale.light2`)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
# [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=h1) Report
> Merging [#12326](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=desc) (6d29c02) into [master](https://codecov.io/gh/apache/superset/commit/f48284909dde84d13276bb40ddd91ec6935f10e5?el=desc) (f482849) will **decrease** coverage by `4.51%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12326 +/- ##
==========================================
- Coverage 67.15% 62.64% -4.52%
==========================================
Files 1002 1002
Lines 49324 49313 -11
Branches 5020 5020
==========================================
- Hits 33124 30892 -2232
- Misses 16075 18217 +2142
- Partials 125 204 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.17% <50.00%> (+<0.01%)` | :arrow_up: |
| python | `63.59% <ø> (-0.56%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `85.36% <ø> (-4.88%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `2.59% <0.00%> (-77.28%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `42.85% <ø> (-26.20%)` | :arrow_down: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `63.88% <50.00%> (-23.62%)` | :arrow_down: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `42.85% <100.00%> (-32.76%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [200 more](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=footer). Last update [f482849...6d29c02](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-758194366
Hoping E2E tests go through on this new run, will merge if so!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-758217321
@pkdotson need to confirm the layout issues in advanced analytics are being taken care of 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-758202382
@mihir174 want to bring this to your awareness
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756144213
thank you @adam-stasiak for spotting the issue!
if the code looks good and we can confirm the styling issue preexists. let's merge this PR.
@michael-s-Molina please open up a separate PR for the rolling function glitch,. thanks so much fo the fix!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #12326:
URL: https://github.com/apache/superset/pull/12326#discussion_r553579387
##########
File path: superset-frontend/stylesheets/less/cosmo/variables.less
##########
@@ -91,7 +91,7 @@
//
// ## Define common padding and border radius sizes and more. Values based on 14px text and 1.428 line-height (~20px to start).
-@padding-base-vertical: 10px;
+@padding-base-vertical: 6.5px;
Review comment:
I did a visual audit of most screens and I didn't found any problem. It shouldn't cause any problem because this is a configurable variable of Bootstrap. To limit the scope of this change we need to track all components that use classes that depend on this variable and apply Emotion styles individually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
# [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=h1) Report
> Merging [#12326](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=desc) (6d29c02) into [master](https://codecov.io/gh/apache/superset/commit/f48284909dde84d13276bb40ddd91ec6935f10e5?el=desc) (f482849) will **decrease** coverage by `5.97%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12326 +/- ##
==========================================
- Coverage 67.15% 61.17% -5.98%
==========================================
Files 1002 517 -485
Lines 49324 19438 -29886
Branches 5020 5020
==========================================
- Hits 33124 11892 -21232
+ Misses 16075 7342 -8733
- Partials 125 204 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.17% <50.00%> (+<0.01%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `85.36% <ø> (-4.88%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `2.59% <0.00%> (-77.28%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `42.85% <ø> (-26.20%)` | :arrow_down: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `63.88% <50.00%> (-23.62%)` | :arrow_down: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `42.85% <100.00%> (-32.76%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [677 more](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=footer). Last update [f482849...6d29c02](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756145928
> thank you @adam-stasiak for spotting the issue!
> if the code looks good and we can confirm the styling issue preexists. let's merge this PR.
We can't merge it just yet. Although this problem exists in master, some inputs became bigger and when we hover them we have some layout problems. I'm fixing this right now and I'll also fix the preexisting problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #12326:
URL: https://github.com/apache/superset/pull/12326
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina removed a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
michael-s-molina removed a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756115362
> Could you verify as well situation when we try to click on
> 
> And then try to expand dropdowns:
>
> dropdown.mov
@adam-stasiak I just confirmed that this is happening in master. Can you open a new issue and remove this comment so we can keep only related issues?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12326: fix: control panel fields styling (#12236)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756087267
# [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=h1) Report
> Merging [#12326](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=desc) (58bc312) into [master](https://codecov.io/gh/apache/superset/commit/4cf3f99ee881a10995212828494f0b126dd5415e?el=desc) (4cf3f99) will **decrease** coverage by `3.33%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12326 +/- ##
==========================================
- Coverage 66.79% 63.45% -3.34%
==========================================
Files 1014 485 -529
Lines 49524 29884 -19640
Branches 5077 0 -5077
==========================================
- Hits 33079 18963 -14116
+ Misses 16314 10921 -5393
+ Partials 131 0 -131
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.45% <ø> (-0.62%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `82.45% <0.00%> (-3.51%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [532 more](https://codecov.io/gh/apache/superset/pull/12326/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=footer). Last update [4cf3f99...58bc312](https://codecov.io/gh/apache/superset/pull/12326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org