You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/01/15 13:26:56 UTC
[GitHub] [rocketmq-dashboard] zhangjidi2016 commented on a change in pull request #69: [ISSUE #68]Use multithreading for topic data collection in collectTask
zhangjidi2016 commented on a change in pull request #69:
URL: https://github.com/apache/rocketmq-dashboard/pull/69#discussion_r785308006
##########
File path: src/main/resources/application.yml
##########
@@ -41,8 +41,9 @@ rocketmq:
# if this value is empty,use env value rocketmq.config.namesrvAddr NAMESRV_ADDR | now, default localhost:9876
# configure multiple namesrv addresses to manage multiple different clusters
namesrvAddrs:
- - 127.0.0.1:9876
- - 127.0.0.2:9876
+# - 10.253.141.99:9876;10.253.141.102:9876
+ - 100.76.6.97:9876
Review comment:
Forgot to change back when testing locally
##########
File path: src/main/java/org/apache/rocketmq/dashboard/task/CollectTaskRunnble.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.dashboard.task;
+
+import com.google.common.base.Throwables;
+import com.google.common.collect.Lists;
+import java.math.BigDecimal;
+import java.util.Date;
+import java.util.List;
+import java.util.concurrent.ExecutionException;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.rocketmq.common.MixAll;
+import org.apache.rocketmq.common.protocol.body.BrokerStatsData;
+import org.apache.rocketmq.common.protocol.body.GroupList;
+import org.apache.rocketmq.common.protocol.route.BrokerData;
+import org.apache.rocketmq.common.protocol.route.TopicRouteData;
+import org.apache.rocketmq.dashboard.service.DashboardCollectService;
+import org.apache.rocketmq.store.stats.BrokerStatsManager;
+import org.apache.rocketmq.tools.admin.MQAdminExt;
+import org.apache.rocketmq.tools.command.stats.StatsAllSubCommand;
+
+@Slf4j
+public class CollectTaskRunnble implements Runnable {
+
+ private String topic;
+
+ private MQAdminExt mqAdminExt;
+
+ private DashboardCollectService dashboardCollectService;
+
+ public CollectTaskRunnble(String topic, MQAdminExt mqAdminExt,
+ DashboardCollectService dashboardCollectService) {
+ this.topic = topic;
+ this.mqAdminExt = mqAdminExt;
+ this.dashboardCollectService = dashboardCollectService;
+ }
+
+ @Override
+ public void run() {
+ Date date = new Date();
+ try {
+ TopicRouteData topicRouteData = mqAdminExt.examineTopicRouteInfo(topic);
+ GroupList groupList = mqAdminExt.queryTopicConsumeByWho(topic);
+ double inTPS = 0;
+ long inMsgCntToday = 0;
+ double outTPS = 0;
+ long outMsgCntToday = 0;
+ for (BrokerData bd : topicRouteData.getBrokerDatas()) {
+ String masterAddr = bd.getBrokerAddrs().get(MixAll.MASTER_ID);
+ if (masterAddr != null) {
+ try {
+ BrokerStatsData bsd = mqAdminExt.viewBrokerStatsData(masterAddr, BrokerStatsManager.TOPIC_PUT_NUMS, topic);
+ inTPS += bsd.getStatsMinute().getTps();
+ inMsgCntToday += StatsAllSubCommand.compute24HourSum(bsd);
+ } catch (Exception e) {
+ log.warn("Exception caught: mqAdminExt get broker stats data TOPIC_PUT_NUMS failed");
Review comment:
done
##########
File path: src/main/java/org/apache/rocketmq/dashboard/task/CollectTaskRunnble.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.dashboard.task;
+
+import com.google.common.base.Throwables;
+import com.google.common.collect.Lists;
+import java.math.BigDecimal;
+import java.util.Date;
+import java.util.List;
+import java.util.concurrent.ExecutionException;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.rocketmq.common.MixAll;
+import org.apache.rocketmq.common.protocol.body.BrokerStatsData;
+import org.apache.rocketmq.common.protocol.body.GroupList;
+import org.apache.rocketmq.common.protocol.route.BrokerData;
+import org.apache.rocketmq.common.protocol.route.TopicRouteData;
+import org.apache.rocketmq.dashboard.service.DashboardCollectService;
+import org.apache.rocketmq.store.stats.BrokerStatsManager;
+import org.apache.rocketmq.tools.admin.MQAdminExt;
+import org.apache.rocketmq.tools.command.stats.StatsAllSubCommand;
+
+@Slf4j
+public class CollectTaskRunnble implements Runnable {
+
+ private String topic;
+
+ private MQAdminExt mqAdminExt;
+
+ private DashboardCollectService dashboardCollectService;
+
+ public CollectTaskRunnble(String topic, MQAdminExt mqAdminExt,
+ DashboardCollectService dashboardCollectService) {
+ this.topic = topic;
+ this.mqAdminExt = mqAdminExt;
+ this.dashboardCollectService = dashboardCollectService;
+ }
+
+ @Override
+ public void run() {
+ Date date = new Date();
+ try {
+ TopicRouteData topicRouteData = mqAdminExt.examineTopicRouteInfo(topic);
+ GroupList groupList = mqAdminExt.queryTopicConsumeByWho(topic);
+ double inTPS = 0;
+ long inMsgCntToday = 0;
+ double outTPS = 0;
+ long outMsgCntToday = 0;
+ for (BrokerData bd : topicRouteData.getBrokerDatas()) {
+ String masterAddr = bd.getBrokerAddrs().get(MixAll.MASTER_ID);
+ if (masterAddr != null) {
+ try {
+ BrokerStatsData bsd = mqAdminExt.viewBrokerStatsData(masterAddr, BrokerStatsManager.TOPIC_PUT_NUMS, topic);
+ inTPS += bsd.getStatsMinute().getTps();
+ inMsgCntToday += StatsAllSubCommand.compute24HourSum(bsd);
+ } catch (Exception e) {
+ log.warn("Exception caught: mqAdminExt get broker stats data TOPIC_PUT_NUMS failed");
+ log.warn("Response [{}] ", e.getMessage());
+ }
+ }
+ }
+ if (groupList != null && !groupList.getGroupList().isEmpty()) {
+ for (String group : groupList.getGroupList()) {
+ for (BrokerData bd : topicRouteData.getBrokerDatas()) {
+ String masterAddr = bd.getBrokerAddrs().get(MixAll.MASTER_ID);
+ if (masterAddr != null) {
+ try {
+ String statsKey = String.format("%s@%s", topic, group);
+ BrokerStatsData bsd = mqAdminExt.viewBrokerStatsData(masterAddr, BrokerStatsManager.GROUP_GET_NUMS, statsKey);
+ outTPS += bsd.getStatsMinute().getTps();
+ outMsgCntToday += StatsAllSubCommand.compute24HourSum(bsd);
+ } catch (Exception e) {
+ log.warn("Exception caught: mqAdminExt get broker stats data GROUP_GET_NUMS failed");
+ log.warn("Response [{}] ", e.getMessage());
+ }
+ }
+ }
+ }
+ }
+
+ List<String> list;
+ try {
+ list = dashboardCollectService.getTopicMap().get(topic);
+ } catch (ExecutionException e) {
+ throw Throwables.propagate(e);
+ }
+ if (null == list) {
+ list = Lists.newArrayList();
+ }
+
+ list.add(date.getTime() + "," + new BigDecimal(inTPS).setScale(5, BigDecimal.ROUND_HALF_UP) + "," + inMsgCntToday + "," + new BigDecimal(outTPS).setScale(5, BigDecimal.ROUND_HALF_UP) + "," + outMsgCntToday);
+ dashboardCollectService.getTopicMap().put(topic, list);
+ } catch (Exception e) {
+ e.printStackTrace();
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org