You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/27 02:11:24 UTC
[GitHub] [spark] maropu commented on a change in pull request #30515: [SPARK-33570][SQL][TESTS] Set the proper version of gssapi plugin automatically for MariaDBKrbIntegrationsuite
maropu commented on a change in pull request #30515:
URL: https://github.com/apache/spark/pull/30515#discussion_r531344417
##########
File path: external/docker-integration-tests/src/test/resources/mariadb_docker_entrypoint.sh
##########
@@ -18,7 +18,7 @@
dpkg-divert --add /bin/systemctl && ln -sT /bin/true /bin/systemctl
apt update
-apt install -y mariadb-plugin-gssapi-server=1:10.5.5+maria~focal
+apt install -y mariadb-plugin-gssapi-server=$(dpkg -s mariadb-server | sed -n "s/^Version: \(.*\)/\1/p")
Review comment:
nit: How about logging which version is installed like this?
```
XXXXX=$(dpkg -s mariadb-server | sed -n "s/^Version: \(.*\)/\1/p")
echo ".... $XXXXX...."
apt install -y mariadb-plugin-gssapi-server=${XXXXXX}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org