You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/01/15 20:22:42 UTC
[GitHub] [incubator-hudi] prashantwason opened a new pull request #1232:
[HUDI-529] Added cobertura coverage reporting support.
prashantwason opened a new pull request #1232: [HUDI-529] Added cobertura coverage reporting support.
URL: https://github.com/apache/incubator-hudi/pull/1232
## What is the purpose of the pull request
Hudi project has code coverage enabled via the jacoco plugin. Jenkins has better support for coverage reporting using the Jenkins Cobertura plugin.
This enhancement provides a way to convert the jacoco coverage report to cobertura format at the end of the unit test runs.
## Brief change log
1. Fixed the jacoco coverage settings
- the jacoco agent was not being loaded as the SureFire plugins argLine was not set correctly
2. The jacoco coverage report is converted to cobertura report format after test completion using the gradle jacobo plugin.
3. There is a specific gradle job defined for the conversion. Modules which do not run tests use a "noop" job.
4. When tests are skipped (-DskipTests) the gradle job is set to noop to prevent the conversion.
## Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
It has been tested to generate the coverage reports after a maven test.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] prashantwason commented on issue #1232: [HUDI-529]
Added cobertura coverage reporting support.
Posted by GitBox <gi...@apache.org>.
prashantwason commented on issue #1232: [HUDI-529] Added cobertura coverage reporting support.
URL: https://github.com/apache/incubator-hudi/pull/1232#issuecomment-582105349
We can only use one of jacoco or cobertura plugins as they both work by adding a java-agent to the unit test. I have found that using cobertura plugin doubles the test run time. Also, cobertura seems to be less maintained (last release was in 2015). So its better to use jacoco.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] n3nash edited a comment on issue #1232: [HUDI-529]
Added cobertura coverage reporting support.
Posted by GitBox <gi...@apache.org>.
n3nash edited a comment on issue #1232: [HUDI-529] Added cobertura coverage reporting support.
URL: https://github.com/apache/incubator-hudi/pull/1232#issuecomment-578981750
@vinothchandar could you share your concerns with introducing gradle as a plugin please ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] prashantwason commented on issue #1232: [HUDI-529]
Added cobertura coverage reporting support.
Posted by GitBox <gi...@apache.org>.
prashantwason commented on issue #1232: [HUDI-529] Added cobertura coverage reporting support.
URL: https://github.com/apache/incubator-hudi/pull/1232#issuecomment-594271065
We have equally good online code coverage reporting at CodeCov now. So this change is not required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] prashantwason closed pull request #1232:
[HUDI-529] Added cobertura coverage reporting support.
Posted by GitBox <gi...@apache.org>.
prashantwason closed pull request #1232: [HUDI-529] Added cobertura coverage reporting support.
URL: https://github.com/apache/incubator-hudi/pull/1232
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1232: [HUDI-529]
Added cobertura coverage reporting support.
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1232: [HUDI-529] Added cobertura coverage reporting support.
URL: https://github.com/apache/incubator-hudi/pull/1232#issuecomment-581801761
@n3nash just want to avoid bringing in a new build system just for this, when things like this exist https://www.mojohaus.org/cobertura-maven-plugin/
Slowly overtime, people will add things to gradle.. and I am concerned it will get out of hands
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1232: [HUDI-529]
Added cobertura coverage reporting support.
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1232: [HUDI-529] Added cobertura coverage reporting support.
URL: https://github.com/apache/incubator-hudi/pull/1232#issuecomment-582756949
I see you want gradle mostly because of jacobo? Lets hash out the need for bringing in gradle, which seems like an overkill..
you can just an extra step in jenkins in a script like this ? https://github.com/rix0rrr/cover2cover (don't know if this specific one works. but you get my general point) .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] prashantwason commented on issue #1232: [HUDI-529]
Added cobertura coverage reporting support.
Posted by GitBox <gi...@apache.org>.
prashantwason commented on issue #1232: [HUDI-529] Added cobertura coverage reporting support.
URL: https://github.com/apache/incubator-hudi/pull/1232#issuecomment-577461980
The build fails as gradle could not be downloaded from the http location.
Access denied to: http://repo.gradle.org/gradle/libs-releases-local/org/gradle/gradle-tooling-api/2.13/gradle-tooling-api-2.13.pom , ReasonPhrase:Forbidden. -> [Help 1]
I will look into upgrading the plugin as the http access is not allowed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] n3nash commented on issue #1232: [HUDI-529] Added
cobertura coverage reporting support.
Posted by GitBox <gi...@apache.org>.
n3nash commented on issue #1232: [HUDI-529] Added cobertura coverage reporting support.
URL: https://github.com/apache/incubator-hudi/pull/1232#issuecomment-578981750
@vinothchandar could you share your concerns with introducing gradle please ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on issue #1232: [HUDI-529] Added
cobertura coverage reporting support.
Posted by GitBox <gi...@apache.org>.
leesf commented on issue #1232: [HUDI-529] Added cobertura coverage reporting support.
URL: https://github.com/apache/incubator-hudi/pull/1232#issuecomment-575630719
Would you please fix the travis failure first? @prashantwason
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services