[GitHub] [incubator-mxnet] yuxihu commented on a change in pull request #14911: Use std::exception as the param in engine complete callback

[GitBox <gi...@apache.org>]

yuxihu commented on a change in pull request #14911: Use std::exception as the param in engine complete callback
URL: https://github.com/apache/incubator-mxnet/pull/14911#discussion_r281835541
 
 

 ##########
 File path: include/mxnet/engine.h
 ##########
 @@ -74,15 +74,15 @@ class CallbackOnComplete {
  public:
   // use implicit copy and assign
   /*! \brief involve the callback */
-  inline void operator()(const dmlc::Error* error = nullptr) const {
+  inline void operator()(const std::exception* error = nullptr) const {
 
 Review comment:
   No, there is no need for this in Horovod at this moment. dmlc exception is a subclass of std::exception. I feel it is better to be more generic on the interface. Additionally, your recent improvements on exception handling also catches a broader range to exceptions using std::exception instead of dmlc::Error.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services