You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/07 10:52:07 UTC
[GitHub] [airflow] ashb commented on a change in pull request #13526: Make helm chart commands compatible with 1.10.14 image
ashb commented on a change in pull request #13526:
URL: https://github.com/apache/airflow/pull/13526#discussion_r553253450
##########
File path: chart/templates/webserver/webserver-deployment.yaml
##########
@@ -94,7 +94,7 @@ spec:
- name: webserver
image: {{ template "airflow_image" . }}
imagePullPolicy: {{ .Values.images.airflow.pullPolicy }}
- args: ["airflow", "webserver"]
+ args: ["bash", "-c", "airflow webserver"]
Review comment:
```suggestion
args: ["bash", "-c", "exec airflow webserver"]
```
##########
File path: chart/templates/scheduler/scheduler-deployment.yaml
##########
@@ -107,7 +107,7 @@ spec:
- name: scheduler
image: {{ template "airflow_image" . }}
imagePullPolicy: {{ .Values.images.airflow.pullPolicy }}
- args: ["airflow", "scheduler"]
+ args: ["bash", "-c", "airflow scheduler"]
Review comment:
```suggestion
args: ["bash", "-c", "exec airflow scheduler"]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org