You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/27 11:54:36 UTC

[GitHub] [flink] pnowojski commented on a diff in pull request #20075: [FLINK-27789][network] Disable overdraft buffer for LegacySource

pnowojski commented on code in PR #20075:
URL: https://github.com/apache/flink/pull/20075#discussion_r907295817


##########
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java:
##########
@@ -385,11 +385,16 @@ public Task(
                 shuffleEnvironment.createShuffleIOOwnerContext(
                         taskNameWithSubtaskAndId, executionId, metrics.getIOMetricGroup());
 
+        boolean overdraftBufferEnabled =
+                !nameOfInvokableClass.equals(
+                        "org.apache.flink.streaming.runtime.tasks.SourceStreamTask");

Review Comment:
   I wonder if it would have been better to have:
   
   -  `LocalBufferPool#maxOverdraftBuffersPerGate` mutable (non-final)
   - provide setter `LocalBufferPool#setMaxOverdraftBuffers`
   - call this setter from within `SourceStreamTask`
   
   ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org