You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/03 10:12:52 UTC

[GitHub] [airflow] XD-DENG commented on a change in pull request #13446: Add docker health check to integrations

XD-DENG commented on a change in pull request #13446:
URL: https://github.com/apache/airflow/pull/13446#discussion_r550985216



##########
File path: scripts/ci/docker-compose/backend-mysql.yml
##########
@@ -36,6 +38,12 @@ services:
       - ../mysql/conf.d:/etc/mysql/conf.d:ro
       - /dev/urandom:/dev/random   # Required to get non-blocking entropy source
       - mysql-db-volume:/var/lib/mysql
+    healthcheck:
+      test: ["CMD", "mysql", "-h", "localhost", "-P", "3306", "-u", "root", "-e", "SELECT 1"]
+      interval: 10s
+      timeout: 10s
+      retries: 120
+

Review comment:
       Is there any specific reason why `restart: always` is not added for `mysql` and `postgres`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org