You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Paul-Blanchaert (via GitHub)" <gi...@apache.org> on 2023/02/02 17:31:42 UTC
[GitHub] [solr] Paul-Blanchaert opened a new pull request, #1325: SOLR-16631: solr.allowUrls - hostnames should be treated in case insensitive way
Paul-Blanchaert opened a new pull request, #1325:
URL: https://github.com/apache/solr/pull/1325
https://issues.apache.org/jira/browse/SOLR-16631
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Given that hostnames should be case insensitive (see [rfc3986;section-6.2.2.1](https://www.rfc-editor.org/rfc/rfc3986#section-6.2.2.1)), the check for should also consider hostnames in urls in a case insentive way.
# Solution
hostPort checking is now ignoring the case
# Tests
Changed existing tests with mixed cases in the host name
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [X] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [X] I have developed this patch against the `main` branch.
- [X] I have run `./gradlew check`.
- [X] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1325: SOLR-16631: solr.allowUrls - hostnames should be treated in case insensitive way
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1325:
URL: https://github.com/apache/solr/pull/1325#issuecomment-1419039510
@Paul-Blanchaert can you either give me ability to commit (Push?) changes to the PR, or modify the change log to add a ` via Eric Pugh` and then I'll merge! Thanks for the contirbution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] Paul-Blanchaert commented on pull request #1325: SOLR-16631: solr.allowUrls - hostnames should be treated in case insensitive way
Posted by "Paul-Blanchaert (via GitHub)" <gi...@apache.org>.
Paul-Blanchaert commented on PR #1325:
URL: https://github.com/apache/solr/pull/1325#issuecomment-1416224562
I gave it a try...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #1325: SOLR-16631: solr.allowUrls - hostnames should be treated in case insensitive way
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #1325:
URL: https://github.com/apache/solr/pull/1325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org