You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/05/04 03:02:55 UTC

Review Request: Fixed garbage collection to allow for disk head room.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10938/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ben Mahler.


Description
-------

See summary.


Diffs
-----

  src/slave/constants.hpp ca1124afff9ef989c05723e314ea40555303a8ff 
  src/slave/constants.cpp 6cd97f97659d68297829c67a7513a193214c9a4a 
  src/slave/slave.cpp 86a15fce93e6aa3f7a8f9700ef2dcea26fda0d87 
  src/tests/gc_tests.cpp 9cd3dfb7a67e435eb31693b887451970a8b4a90b 

Diff: https://reviews.apache.org/r/10938/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request: Fixed garbage collection to allow for disk head room.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10938/#review20154
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On May 4, 2013, 1:02 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10938/
> -----------------------------------------------------------
> 
> (Updated May 4, 2013, 1:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp ca1124afff9ef989c05723e314ea40555303a8ff 
>   src/slave/constants.cpp 6cd97f97659d68297829c67a7513a193214c9a4a 
>   src/slave/slave.cpp 86a15fce93e6aa3f7a8f9700ef2dcea26fda0d87 
>   src/tests/gc_tests.cpp 9cd3dfb7a67e435eb31693b887451970a8b4a90b 
> 
> Diff: https://reviews.apache.org/r/10938/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request: Fixed garbage collection to allow for disk head room.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10938/
-----------------------------------------------------------

(Updated May 4, 2013, 1:11 a.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

minor fixes. nnfr.


Description
-------

See summary.


Diffs (updated)
-----

  src/slave/constants.hpp ca1124afff9ef989c05723e314ea40555303a8ff 
  src/slave/constants.cpp 6cd97f97659d68297829c67a7513a193214c9a4a 
  src/slave/slave.cpp 86a15fce93e6aa3f7a8f9700ef2dcea26fda0d87 
  src/tests/gc_tests.cpp 9cd3dfb7a67e435eb31693b887451970a8b4a90b 

Diff: https://reviews.apache.org/r/10938/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request: Fixed garbage collection to allow for disk head room.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10938/#review20155
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On May 4, 2013, 1:02 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10938/
> -----------------------------------------------------------
> 
> (Updated May 4, 2013, 1:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp ca1124afff9ef989c05723e314ea40555303a8ff 
>   src/slave/constants.cpp 6cd97f97659d68297829c67a7513a193214c9a4a 
>   src/slave/slave.cpp 86a15fce93e6aa3f7a8f9700ef2dcea26fda0d87 
>   src/tests/gc_tests.cpp 9cd3dfb7a67e435eb31693b887451970a8b4a90b 
> 
> Diff: https://reviews.apache.org/r/10938/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>