You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/02/11 10:46:46 UTC
[GitHub] [dubbo] codecov-commenter commented on pull request #11529: Metrics Count Optimization
codecov-commenter commented on PR #11529:
URL: https://github.com/apache/dubbo/pull/11529#issuecomment-1426695640
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/11529?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11529](https://codecov.io/gh/apache/dubbo/pull/11529?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cbfa982) into [3.2](https://codecov.io/gh/apache/dubbo/commit/62e96dbcd00d45a0ac7c2bb2f3c62f56560f005f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (62e96db) will **decrease** coverage by `4.91%`.
> The diff coverage is `93.83%`.
```diff
@@ Coverage Diff @@
## 3.2 #11529 +/- ##
============================================
- Coverage 69.74% 64.84% -4.91%
+ Complexity 338 14 -324
============================================
Files 1560 1511 -49
Lines 83643 62838 -20805
Branches 15166 9172 -5994
============================================
- Hits 58338 40745 -17593
+ Misses 20423 17854 -2569
+ Partials 4882 4239 -643
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/11529?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/metrics/filter/MetricsCollectExecutor.java](https://codecov.io/gh/apache/dubbo/pull/11529?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWRlZmF1bHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldHJpY3MvZmlsdGVyL01ldHJpY3NDb2xsZWN0RXhlY3V0b3IuamF2YQ==) | `81.81% <85.71%> (ø)` | |
| [...cs/collector/sample/SimpleMetricsCountSampler.java](https://codecov.io/gh/apache/dubbo/pull/11529?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWRlZmF1bHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldHJpY3MvY29sbGVjdG9yL3NhbXBsZS9TaW1wbGVNZXRyaWNzQ291bnRTYW1wbGVyLmphdmE=) | `92.53% <92.53%> (ø)` | |
| [...collector/sample/MetricsCountSampleConfigurer.java](https://codecov.io/gh/apache/dubbo/pull/11529?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWRlZmF1bHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldHJpY3MvY29sbGVjdG9yL3NhbXBsZS9NZXRyaWNzQ291bnRTYW1wbGVDb25maWd1cmVyLmphdmE=) | `94.44% <94.44%> (ø)` | |
| [...bbo/metrics/collector/DefaultMetricsCollector.java](https://codecov.io/gh/apache/dubbo/pull/11529?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWRlZmF1bHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldHJpY3MvY29sbGVjdG9yL0RlZmF1bHRNZXRyaWNzQ29sbGVjdG9yLmphdmE=) | `97.33% <97.72%> (+2.21%)` | :arrow_up: |
| [...org/apache/dubbo/metrics/filter/MetricsFilter.java](https://codecov.io/gh/apache/dubbo/pull/11529?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWRlZmF1bHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldHJpY3MvZmlsdGVyL01ldHJpY3NGaWx0ZXIuamF2YQ==) | `87.50% <100.00%> (-0.74%)` | :arrow_down: |
| [...ava/org/apache/dubbo/metrics/event/EmptyEvent.java](https://codecov.io/gh/apache/dubbo/pull/11529?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9ldmVudC9FbXB0eUV2ZW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...luster/router/script/ScriptStateRouterFactory.java](https://codecov.io/gh/apache/dubbo/pull/11529?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3NjcmlwdC9TY3JpcHRTdGF0ZVJvdXRlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/dubbo/test/common/impl/GreetingServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/11529?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9HcmVldGluZ1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...zookeeper/curator/CuratorZookeeperTransporter.java](https://codecov.io/gh/apache/dubbo/pull/11529?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3Rpbmctem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy96b29rZWVwZXIvY3VyYXRvci9DdXJhdG9yWm9va2VlcGVyVHJhbnNwb3J0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../serialize/hessian2/Hessian2SerializerFactory.java](https://codecov.io/gh/apache/dubbo/pull/11529?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yU2VyaWFsaXplckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [505 more](https://codecov.io/gh/apache/dubbo/pull/11529?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org