You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2019/02/11 17:10:30 UTC

[GitHub] FlorianHockmann commented on issue #1057: Changed loop break check to break out of the connection creation loop

FlorianHockmann commented on issue #1057: Changed loop break check to break out of the connection creation loop
URL: https://github.com/apache/tinkerpop/pull/1057#issuecomment-462410371
 
 
   Thanks for this contribution.
   I also noticed problems with the way the connection pool now handles resizing and closing of broken connections ([TINKERPOP-2135](https://issues.apache.org/jira/browse/TINKERPOP-2135)) which are probably related. Improving this situation will most likely require a bigger change, but since you have described a concrete problem in TINKERPOP-2155 and because your change is really minimal, I think that it makes sense to merge this to have your problem fixed. We can still improve the other aspects later.
   So: VOTE +1.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services