You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "abumarjikar (via GitHub)" <gi...@apache.org> on 2025/08/15 17:59:50 UTC
[PR] SOLR-17830: Restore V1 Api fix parameter name used to create collection object. [solr]
abumarjikar opened a new pull request, #3479:
URL: https://github.com/apache/solr/pull/3479
https://issues.apache.org/jira/browse/SOLR-17830
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-17830: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
This PR targets to correct the param name used to create collection when restore collection is called.
# Solution
Added Optional<String> to method for building restore request
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17830: Restore V1 Api fix parameter name used to create collection object. [solr]
Posted by "abumarjikar (via GitHub)" <gi...@apache.org>.
abumarjikar commented on PR #3479:
URL: https://github.com/apache/solr/pull/3479#issuecomment-3196110619
@epugh @gerlowskija Need confirmation on which bug fix version this should go? So that i can add in release notes and in changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17830: Restore V1 Api fix parameter name used to create collection object. [solr]
Posted by "abumarjikar (via GitHub)" <gi...@apache.org>.
abumarjikar commented on code in PR #3479:
URL: https://github.com/apache/solr/pull/3479#discussion_r2281567662
##########
solr/core/src/test/org/apache/solr/handler/admin/api/RestoreCollectionAPITest.java:
##########
@@ -45,10 +45,13 @@
import org.apache.solr.request.LocalSolrQueryRequest;
import org.junit.BeforeClass;
import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/** Unit tests for {@link RestoreCollection} */
public class RestoreCollectionAPITest extends SolrTestCaseJ4 {
+ private static final Logger log = LoggerFactory.getLogger(RestoreCollectionAPITest.class);
Review Comment:
Right. I will remove this in next commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17830: Restore V1 Api fix parameter name used to create collection object. [solr]
Posted by "iamsanjay (via GitHub)" <gi...@apache.org>.
iamsanjay commented on PR #3479:
URL: https://github.com/apache/solr/pull/3479#issuecomment-3209816742
@gerlowskija build failing
https://ci-builds.apache.org/job/Solr/job/Solr-Smoketest-9.9/45/
duplicate section "Release 9.9.1 " under release "9.9.1"
https://github.com/apache/solr/blob/branch_9_9/solr/CHANGES.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17830: Restore V1 Api fix parameter name used to create collection object. [solr]
Posted by "abumarjikar (via GitHub)" <gi...@apache.org>.
abumarjikar commented on code in PR #3479:
URL: https://github.com/apache/solr/pull/3479#discussion_r2282001010
##########
solr/core/src/java/org/apache/solr/handler/admin/api/CreateCollection.java:
##########
@@ -291,10 +292,10 @@ private static void createSysConfigSet(CoreContainer coreContainer)
}
public static CreateCollectionRequestBody createRequestBodyFromV1Params(
- SolrParams params, boolean nameRequired) {
+ SolrParams params, boolean nameRequired, Optional<String> propertyName) {
final var requestBody = new CreateCollectionRequestBody();
- requestBody.name =
- nameRequired ? params.required().get(CommonParams.NAME) : params.get(CommonParams.NAME);
+ final var NAME = propertyName.orElse(CommonParams.NAME);
Review Comment:
changes done to reduce the overhead of using other option. just provided what is need for create collection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17830: Restore V1 Api fix parameter name used to create collection object. [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #3479:
URL: https://github.com/apache/solr/pull/3479#issuecomment-3192411506
I clicked the run tests, and looks like some changes needed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17830: Restore V1 Api fix parameter name used to create collection object. [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #3479:
URL: https://github.com/apache/solr/pull/3479#discussion_r2279662809
##########
solr/core/src/java/org/apache/solr/handler/admin/api/CreateCollection.java:
##########
@@ -291,10 +292,10 @@ private static void createSysConfigSet(CoreContainer coreContainer)
}
public static CreateCollectionRequestBody createRequestBodyFromV1Params(
- SolrParams params, boolean nameRequired) {
+ SolrParams params, boolean nameRequired, Optional<String> propertyName) {
final var requestBody = new CreateCollectionRequestBody();
- requestBody.name =
- nameRequired ? params.required().get(CommonParams.NAME) : params.get(CommonParams.NAME);
+ final var NAME = propertyName.orElse(CommonParams.NAME);
Review Comment:
`name` is a perfectly fine variable name.
##########
solr/core/src/test/org/apache/solr/handler/admin/api/RestoreCollectionAPITest.java:
##########
@@ -45,10 +45,13 @@
import org.apache.solr.request.LocalSolrQueryRequest;
import org.junit.BeforeClass;
import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/** Unit tests for {@link RestoreCollection} */
public class RestoreCollectionAPITest extends SolrTestCaseJ4 {
+ private static final Logger log = LoggerFactory.getLogger(RestoreCollectionAPITest.class);
Review Comment:
I don't think this is needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17830: Restore V1 Api fix parameter name used to create collection object. [solr]
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #3479:
URL: https://github.com/apache/solr/pull/3479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org