[GitHub] leventov commented on a change in pull request #6662: Double-checked locking bug is fixed.

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #6662: Double-checked locking bug is fixed.
URL: https://github.com/apache/incubator-druid/pull/6662#discussion_r236307911
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/extraction/JavaScriptExtractionFn.java
 ##########
 @@ -120,18 +120,14 @@ public String apply(@Nullable Object value)
    * {@link #apply(Object)} can be called by multiple threads, so this function should be thread-safe to avoid extra
    * script compilation.
    */
-  private void checkAndCompileScript()
+  private synchronized void checkAndCompileScript()
 
 Review comment:
   Same as in `JavaScriptAggregatorFactory`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org