[GitHub] [incubator-inlong] gong commented on a diff in pull request #3882: [INLONG-3822][Sort] Add node relations definition to support transform

[GitBox <gi...@apache.org>]

gong commented on code in PR #3882:
URL: https://github.com/apache/incubator-inlong/pull/3882#discussion_r856251125


##########
inlong-sort/sort-common/src/test/java/org/apache/inlong/sort/protocol/transformation/relation/InnerJoinNodeRelationTest.java:
##########
@@ -38,10 +38,15 @@
 import static org.junit.Assert.assertEquals;
 
 /**
- * Tests for{@link InnerJoinNodeRelationTest}
+ * Tests for {@link InnerJoinNodeRelationTest}

Review Comment:
   `InnerJoinNodeRelationTest` should be InnerJoinNodeRelation



##########
inlong-sort/sort-common/src/test/java/org/apache/inlong/sort/protocol/transformation/relation/LeftOuterJoinNodeRelationTest.java:
##########
@@ -38,10 +38,15 @@
 import static org.junit.Assert.assertEquals;
 
 /**
- * Tests for{@link LeftOuterJoinNodeRelationTest}
+ * Tests for {@link LeftOuterJoinNodeRelationTest}

Review Comment:
   `LeftOuterJoinNodeRelationTest` should be LeftOuterJoinNodeRelation



##########
inlong-sort/sort-common/src/test/java/org/apache/inlong/sort/protocol/transformation/relation/UnionNodeRelationTest.java:
##########
@@ -26,10 +26,15 @@
 import static org.junit.Assert.assertEquals;
 
 /**
- * Tests for{@link UnionNodeRelationTest}
+ * Tests for {@link UnionNodeRelationTest}

Review Comment:
   `UnionNodeRelationTest` should be UnionNodeRelation



##########
inlong-sort/sort-common/src/test/java/org/apache/inlong/sort/protocol/transformation/relation/NodeRelationTest.java:
##########
@@ -25,10 +25,15 @@
 import static org.junit.Assert.assertEquals;
 
 /**
- * Tests for{@link NodeRelationTest}
+ * Tests for {@link NodeRelationTest}

Review Comment:
   `NodeRelationTest` should be NodeRelation



##########
inlong-sort/sort-common/src/test/java/org/apache/inlong/sort/protocol/transformation/relation/RightOuterJoinNodeRelationTest.java:
##########
@@ -37,10 +37,15 @@
 import static org.junit.Assert.assertEquals;
 
 /**
- * Tests for{@link RightOuterJoinNodeRelationTest}
+ * Tests for {@link RightOuterJoinNodeRelationTest}

Review Comment:
   `RightOuterJoinNodeRelationTest` should be RightOuterJoinNodeRelation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org