You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "knyk-dev (via GitHub)" <gi...@apache.org> on 2026/03/30 15:32:17 UTC
[PR] fix: align TCC resource manager fallback behavior [incubator-seata-go]
knyk-dev opened a new pull request, #1091:
URL: https://github.com/apache/incubator-seata-go/pull/1091
<!-- Thanks for sending a pull request!
-->
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](https://github.com/apache/incubator-seata-go/tree/master/changes).
**What this PR does**:
As discussed in the recent community bi-weekly meeting, the missing implementations in `TCCResourceManager` cause panics when invoked, which is dangerous for the framework's stability.
Thanks to @CAICAIIs for raising this issue and providing the excellent Java-side research!
- replace `panic("implement me")` in `TCCResourceManager.LockQuery` with an explicit fallback return: `false, nil`
- replace `panic("implement me")` in `TCCResourceManager.UnregisterResource` with an explicit unsupported error
- add regression tests to verify both fallback paths no longer panic
**Which issue(s) this PR fixes**:
Fixes #1072
**Special notes for your reviewer**:
Seata Java `2.x` does not provide a TCC-specific implementation for these two methods either.
`TCCResourceManager` inherits the default fallback behavior from `AbstractResourceManager`:
- `lockQuery(...)` returns `false`
- `unregisterResource(...)` throws `NotSupportYetException`
This PR keeps the change small and makes the current fallback behavior explicit on the Go side, while leaving future TCC lifecycle changes to a separate discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: align TCC resource manager fallback behavior [incubator-seata-go]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1091:
URL: https://github.com/apache/incubator-seata-go/pull/1091#issuecomment-4156010040
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1091?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 57.00%. Comparing base ([`f081d6e`](https://app.codecov.io/gh/apache/incubator-seata-go/commit/f081d6efc9ed650cc926476353380ca797267055?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93a76c9`](https://app.codecov.io/gh/apache/incubator-seata-go/commit/93a76c998b8eb83b7888c930773daaf6ad0daec8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1091 +/- ##
==========================================
+ Coverage 56.99% 57.00% +0.01%
==========================================
Files 266 266
Lines 17489 17489
==========================================
+ Hits 9967 9969 +2
+ Misses 6701 6698 -3
- Partials 821 822 +1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1091?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: align TCC resource manager fallback behavior [incubator-seata-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks merged PR #1091:
URL: https://github.com/apache/incubator-seata-go/pull/1091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org