You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/06/19 00:24:56 UTC

[kudu-CR] [tablet copy client-test] fix compiler warning 

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13674


Change subject: [tablet_copy_client-test] fix compiler warning
......................................................................

[tablet_copy_client-test] fix compiler warning

Fixed compilation warning in TabletCopyClientTest:

  src/kudu/tserver/tablet_copy_client-test.cc:149:16: \
      warning: 'GenerateTestData' overrides a member function but \
      is not marked 'override' [-Winconsistent-missing-override]
    virtual void GenerateTestData() {
                 ^
  src/kudu/tserver/tablet_copy-test-base.h:113:16: \
      note: overridden virtual function is here
    virtual void GenerateTestData() {
                 ^
  1 warning generated.

This patch does not contain any functional modifications.

Change-Id: Ib0194589f7ff38a66dc2ae85ff02f8f9346b1db6
---
M src/kudu/tserver/tablet_copy_client-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/13674/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0194589f7ff38a66dc2ae85ff02f8f9346b1db6
Gerrit-Change-Number: 13674
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [tablet copy client-test] fix compiler warning

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13674 )

Change subject: [tablet_copy_client-test] fix compiler warning
......................................................................


Patch Set 1: Verified+1

Unrelated flakes in TSAN build related to NTP issues.


-- 
To view, visit http://gerrit.cloudera.org:8080/13674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0194589f7ff38a66dc2ae85ff02f8f9346b1db6
Gerrit-Change-Number: 13674
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Jun 2019 00:56:18 +0000
Gerrit-HasComments: No

[kudu-CR] [tablet copy client-test] fix compiler warning

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/13674 )

Change subject: [tablet_copy_client-test] fix compiler warning
......................................................................


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/13674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ib0194589f7ff38a66dc2ae85ff02f8f9346b1db6
Gerrit-Change-Number: 13674
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [tablet copy client-test] fix compiler warning

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13674 )

Change subject: [tablet_copy_client-test] fix compiler warning
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0194589f7ff38a66dc2ae85ff02f8f9346b1db6
Gerrit-Change-Number: 13674
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Jun 2019 01:00:29 +0000
Gerrit-HasComments: No

[kudu-CR] [tablet copy client-test] fix compiler warning

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13674 )

Change subject: [tablet_copy_client-test] fix compiler warning
......................................................................

[tablet_copy_client-test] fix compiler warning

Fixed compilation warning in TabletCopyClientTest:

  src/kudu/tserver/tablet_copy_client-test.cc:149:16: \
      warning: 'GenerateTestData' overrides a member function but \
      is not marked 'override' [-Winconsistent-missing-override]
    virtual void GenerateTestData() {
                 ^
  src/kudu/tserver/tablet_copy-test-base.h:113:16: \
      note: overridden virtual function is here
    virtual void GenerateTestData() {
                 ^
  1 warning generated.

This patch does not contain any functional modifications.

Change-Id: Ib0194589f7ff38a66dc2ae85ff02f8f9346b1db6
Reviewed-on: http://gerrit.cloudera.org:8080/13674
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/tserver/tablet_copy_client-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Alexey Serbin: Verified
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/13674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0194589f7ff38a66dc2ae85ff02f8f9346b1db6
Gerrit-Change-Number: 13674
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>