You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Dhaval Rajpara <dh...@gmail.com> on 2023/05/30 11:24:28 UTC
Review Request 74456: RANGER-4223 : Policy view pop-up does not render deny-all-else toggle.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74456/
-----------------------------------------------------------
Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nitin Galave, Pradeep Agrawal, and Velmurugan Periasamy.
Bugs: RANGER-4223
https://issues.apache.org/jira/browse/RANGER-4223
Repository: ranger
Description
-------
On clicking view button next to a policy, a pop-up windows is rendered showing details of the policy, like the one shown in the attached image. This pop-up does not include the toggle for denyAllElse flag, which is a critical flag to interpret the impact of the policy.
Diffs
-----
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js f15da5f8c
Diff: https://reviews.apache.org/r/74456/diff/1/
Testing
-------
Thanks,
Dhaval Rajpara
Re: Review Request 74456: RANGER-4223 : Policy view pop-up does not render deny-all-else toggle.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74456/#review225493
-----------------------------------------------------------
Dhaval - with this patch, policy view popup shows denyAllElse toggle. However, the popup now includes empty tables for the following:
- Exclude from Allow Conditions
- Deny Condition
- Exclude from Deny Conditions
It will help to not render tables having no entries.
- Madhan Neethiraj
On May 30, 2023, 11:24 a.m., Dhaval Rajpara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74456/
> -----------------------------------------------------------
>
> (Updated May 30, 2023, 11:24 a.m.)
>
>
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nitin Galave, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4223
> https://issues.apache.org/jira/browse/RANGER-4223
>
>
> Repository: ranger
>
>
> Description
> -------
>
> On clicking view button next to a policy, a pop-up windows is rendered showing details of the policy, like the one shown in the attached image. This pop-up does not include the toggle for denyAllElse flag, which is a critical flag to interpret the impact of the policy.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js f15da5f8c
>
>
> Diff: https://reviews.apache.org/r/74456/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dhaval Rajpara
>
>