You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/25 18:11:25 UTC
[GitHub] jeffreythewang opened a new pull request #5485: Fix SQLA
granularity conversion in migration c5756bec8b47
jeffreythewang opened a new pull request #5485: Fix SQLA granularity conversion in migration c5756bec8b47
URL: https://github.com/apache/incubator-superset/pull/5485
This is an extension of https://github.com/apache/incubator-superset/pull/5135, which I believe is originally associated with https://github.com/apache/incubator-superset/pull/4755.
This converts charts that had the old granularity string saved (`"Time Column"`, `"hour"`, `"day"`, `"week"`, etc.) to use ISO duration (`"None"`, `"P1H"`, `"P1D"`, `"P1W"`, etc.).
Also I think it's worth setting up tests for database upgrades and downgrades. I've ran into issues with downgrades before, as I assume they aren't as extensively tested as upgrades.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org