[GitHub] [spark] cloud-fan commented on a diff in pull request #42917: [SPARK-45163][SQL] Merge TABLE_OPERATION & _LEGACY_ERROR_TEMP_1113 into UNSUPPORTED_TABLE_OPERATION and refactor some logic

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #42917:
URL: https://github.com/apache/spark/pull/42917#discussion_r1325993468


##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -3215,11 +3225,6 @@
           "<variableName> is a VARIABLE and cannot be updated using the SET statement. Use SET VARIABLE <variableName> = ... instead."
         ]
       },
-      "TABLE_OPERATION" : {
-        "message" : [
-          "Table <tableName> does not support <operation>. Please check the current catalog and namespace to make sure the qualified table name is expected, and also check the catalog implementation which is configured by \"spark.sql.catalog\"."

Review Comment:
   Let's not degrade the error message. I think there are two kinds if unsupported table operations: 1) the table implementation does not support certain DS v2 features. 2) it's a view not table.
   
   Now my preference is to keep this sub error class here, but add two new error class `EXPECT_VIEW_GOT_TABLE` and `EXPECT_TABLE_GOT_VIEW` to replace the `UNSUPPORTED_TABLE_OPERATION` and `UNSUPPORTED_VIEW_OPERATION`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org