You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "Pearl1594 (via GitHub)" <gi...@apache.org> on 2025/08/25 19:19:54 UTC
[PR] Fix update network offering [cloudstack-terraform-provider]
Pearl1594 opened a new pull request, #206:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/206
- Guest_ip_type and traffic type cannot be updated for a network offering
- Incorrect value is updated (i.e., no matter the parameter that's changed, the network offering's name is modified)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix update network offering [cloudstack-terraform-provider]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on PR #206:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/206#issuecomment-3231315948
Merged this with #205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix update network offering [cloudstack-terraform-provider]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on code in PR #206:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/206#discussion_r2303572507
##########
cloudstack/resource_cloudstack_network_offering.go:
##########
@@ -125,34 +125,34 @@ func resourceCloudStackNetworkOfferingUpdate(d *schema.ResourceData, meta interf
}
- // Check if the guest ip type is changed and if so, update the virtual machine
- if d.HasChange("guest_ip_type") {
- log.Printf("[DEBUG] Guest ip type changed for %s, starting update", name)
+ // Check if maxconnections is changed and if so, update the network offering
Review Comment:
These fields are not defined in the schema. Let's merge this PR with https://github.com/apache/cloudstack-terraform-provider/pull/205/?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix update network offering [cloudstack-terraform-provider]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 closed pull request #206: Fix update network offering
URL: https://github.com/apache/cloudstack-terraform-provider/pull/206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix update network offering [cloudstack-terraform-provider]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 closed pull request #206: Fix update network offering
URL: https://github.com/apache/cloudstack-terraform-provider/pull/206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org