You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/01/08 17:58:43 UTC

[GitHub] [qpid-dispatch] kgiusti opened a new pull request #657: DISPATCH-1544: mask coverity false positive delivery use-after-free

kgiusti opened a new pull request #657: DISPATCH-1544: mask coverity false positive delivery use-after-free
URL: https://github.com/apache/qpid-dispatch/pull/657
 
 
   This patch just adds some debug asserts and extra comments to ensure the delivery reference counts are correct (match the expectations of the code).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #657: DISPATCH-1544: mask coverity false positive delivery use-after-free

Posted by GitBox <gi...@apache.org>.
ganeshmurthy commented on issue #657: DISPATCH-1544: mask coverity false positive delivery use-after-free
URL: https://github.com/apache/qpid-dispatch/pull/657#issuecomment-574690566
 
 
   This commit only adds asserts ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-dispatch] kgiusti commented on issue #657: DISPATCH-1544: mask coverity false positive delivery use-after-free

Posted by GitBox <gi...@apache.org>.
kgiusti commented on issue #657: DISPATCH-1544: mask coverity false positive delivery use-after-free
URL: https://github.com/apache/qpid-dispatch/pull/657#issuecomment-574715180
 
 
   The patch also annotates the code so coverity won't report the use after free issue (see the /* coverity .... */ comments this patch adds).
   
   The asserts are there to prevent future code changes from inadvertently messing up the reference counters - which _could_ introduce a real use-after-free bug which coverity will ignore due to the annotation.
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-dispatch] kgiusti merged pull request #657: DISPATCH-1544: mask coverity false positive delivery use-after-free

Posted by GitBox <gi...@apache.org>.
kgiusti merged pull request #657: DISPATCH-1544: mask coverity false positive delivery use-after-free
URL: https://github.com/apache/qpid-dispatch/pull/657
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org