You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2017/04/21 21:15:50 UTC
Review Request 58630: RANGER-1531: Good coding practice while parsing
XML documents in Ranger
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58630/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1531
https://issues.apache.org/jira/browse/RANGER-1531
Repository: ranger
Description
-------
Added code to not allow external entities as part of XML parsing
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/XMLUtils.java c23161b
agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java e6a19fe
Diff: https://reviews.apache.org/r/58630/diff/1/
Testing
-------
Confirmed all the existing unit tests ran successfully.
Thanks,
Sailaja Polavarapu
Re: Review Request 58630: RANGER-1531: Good coding practice while
parsing XML documents in Ranger
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58630/#review172766
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 21, 2017, 9:15 p.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58630/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 9:15 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1531
> https://issues.apache.org/jira/browse/RANGER-1531
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Added code to not allow external entities as part of XML parsing
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/XMLUtils.java c23161b
> agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java e6a19fe
>
>
> Diff: https://reviews.apache.org/r/58630/diff/1/
>
>
> Testing
> -------
>
> Confirmed all the existing unit tests ran successfully.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>