You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/30 00:50:06 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #17100: WIP: Advanced Params using json-schema

kaxil commented on a change in pull request #17100:
URL: https://github.com/apache/airflow/pull/17100#discussion_r679573636



##########
File path: airflow/models/dag.py
##########
@@ -1976,7 +1981,7 @@ def create_dagrun(
         run_id: Optional[str] = None,
         start_date: Optional[datetime] = None,
         external_trigger: Optional[bool] = False,
-        conf: Optional[dict] = None,
+        conf: Optional[dict] = {},

Review comment:
       This will suffer from one of the common Python gotcha's about Mutable default args
   
   https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org