You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2018/03/26 12:48:57 UTC
Review Request 66278: Ensured correct termination order in
IOSwitchboard's main function.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66278/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Kevin Klues.
Repository: mesos
Description
-------
This patch terminates `IOSwitchboardServer` actor before calling
`process::finalize()`. This patch is an addition to commit 02ebf9986a.
Diffs
-----
src/slave/containerizer/mesos/io/switchboard_main.cpp 3838aac6e560d27f569b78d871dc76dddaf80a82
Diff: https://reviews.apache.org/r/66278/diff/1/
Testing
-------
internal CI
Thanks,
Andrei Budnik
Re: Review Request 66278: Ensured correct termination order in
IOSwitchboard's main function.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66278/#review199962
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On March 26, 2018, 12:48 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66278/
> -----------------------------------------------------------
>
> (Updated March 26, 2018, 12:48 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch terminates `IOSwitchboardServer` actor before calling
> `process::finalize()`. This patch is an addition to commit 02ebf9986a.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard_main.cpp 3838aac6e560d27f569b78d871dc76dddaf80a82
>
>
> Diff: https://reviews.apache.org/r/66278/diff/2/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 66278: Ensured correct termination order in
IOSwitchboard's main function.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66278/#review199966
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66278']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66278
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66278/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (127 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1094 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (45 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (85 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (881 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (905 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (843 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (869 ms total)
[----------] Global test environment tear-down
[==========] 949 tests from 94 test cases ran. (448517 ms total)
[ PASSED ] 948 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 215 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66278/logs/mesos-tests-stderr.log):
```
I0326 13:43:43.016959 3676 slave.cpp:3873] Shutting down framework 0f7f9821-dfad-40ed-8a60-bd841c3197I0326 13:43:42.830972 11608 exec.cpp:162] Version: 1.6.0
I0326 13:43:42.858973 10972 exec.cpp:236] Executor registered on agent 0f7f9821-dfad-40ed-8a60-bd841c319780-S0
I0326 13:43:42.862952 14036 executor.cpp:176] Received SUBSCRIBED event
I0326 13:43:42.867974 14036 executor.cpp:180] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0326 13:43:42.867974 14036 executor.cpp:176] Received LAUNCH event
I0326 13:43:42.872977 14036 executor.cpp:648] Starting task e26937b6-65ef-4ea7-bbc5-f33ec5678b02
I0326 13:43:42.957968 14036 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0326 13:43:42.990983 14036 executor.cpp:661] Forked command at 7460
I0326 13:43:43.018975 3924 exec.cpp:445] Executor asked to shutdown
I0326 13:43:43.019943 6292 executor.cpp:176] Received SHUTDOWN event
I0326 13:43:43.019943 6292 executor.cpp:758] Shutting down
I0326 13:43:43.019943 6292 executor.cpp:868] Sending SIGTERM to process tree at pid 780-0000
I0326 13:43:43.016959 12196 master.cpp:10446] Updating the state of task e26937b6-65ef-4ea7-bbc5-f33ec5678b02 of framework 0f7f9821-dfad-40ed-8a60-bd841c319780-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0326 13:43:43.017976 3676 slave.cpp:6566] Shutting down executor 'e26937b6-65ef-4ea7-bbc5-f33ec5678b02' of framework 0f7f9821-dfad-40ed-8a60-bd841c319780-0000 at executor(1)@10.3.1.8:53364
I0326 13:43:43.018975 3676 slave.cpp:919] Agent terminating
W0326 13:43:43.018975 3676 slave.cpp:3869] Ignoring shutdown framework 0f7f9821-dfad-40ed-8a60-bd841c319780-0000 because it is terminating
I0326 13:43:43.020946 12196 master.cpp:10545] Removing task e26937b6-65ef-4ea7-bbc5-f33ec5678b02 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 0f7f9821-dfad-40ed-8a60-bd841c319780-0000 on agent 0f7f9821-dfad-40ed-8a60-bd841c319780-S0 at slave(418)@10.3.1.8:53343 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0326 13:43:43.021944 4108 containerizer.cpp:2338] Destroying container 7f25b93e-6ca5-45f8-b393-80521ced555c in RUNNING state
I0326 13:43:43.021944 4108 containerizer.cpp:2952] Transitioning the state of container 7f25b93e-6ca5-45f8-b393-80521ced555c from RUNNING to DESTROYING
I0326 13:43:43.022945 4108 launcher.cpp:156] Asked to destroy container 7f25b93e-6ca5-45f8-b393-80521ced555c
I0326 13:43:43.023944 12196 master.cpp:1295] Agent 0f7f9821-dfad-40ed-8a60-bd841c319780-S0 at slave(418)@10.3.1.8:53343 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0326 13:43:43.023944 12196 master.cpp:3283] Disconnecting agent 0f7f9821-dfad-40ed-8a60-bd841c319780-S0 at slave(418)@10.3.1.8:53343 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0326 13:43:43.024956 12196 master.cpp:3302] Deactivating agent 0f7f9821-dfad-40ed-8a60-bd841c319780-S0 at slave(418)@10.3.1.8:53343 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0326 13:43:43.024956 1164 hierarchical.cpp:344] Removed framework 0f7f9821-dfad-40ed-8a60-bd841c319780-0000
I0326 13:43:43.025956 1164 hierarchical.cpp:766] Agent 0f7f9821-dfad-40ed-8a60-bd841c319780-S0 deactivated
I0326 13:43:43.111439 9672 containerizer.cpp:2791] Container 7f25b93e-6ca5-45f8-b393-80521ced555c has exited
I0326 13:43:43.146441 10060 master.cpp:1137] Master terminating
I0326 13:43:43.148442 12248 hierarchical.cpp:609] Removed agent 0f7f9821-dfad-40ed-8a60-bd841c319780-S0
I0326 13:43:43.549456 13728 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 26, 2018, 12:48 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66278/
> -----------------------------------------------------------
>
> (Updated March 26, 2018, 12:48 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch terminates `IOSwitchboardServer` actor before calling
> `process::finalize()`. This patch is an addition to commit 02ebf9986a.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard_main.cpp 3838aac6e560d27f569b78d871dc76dddaf80a82
>
>
> Diff: https://reviews.apache.org/r/66278/diff/2/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>