You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "o-nikolas (via GitHub)" <gi...@apache.org> on 2023/08/15 23:34:59 UTC
[GitHub] [airflow] o-nikolas commented on a diff in pull request #33423: Add a mechanism to warn if executors override existing CLI commands
o-nikolas commented on code in PR #33423:
URL: https://github.com/apache/airflow/pull/33423#discussion_r1295239347
##########
airflow/cli/cli_parser.py:
##########
Review Comment:
Yeah, that's a tough one. I see both sides. If a user really wants their cli command to have a name already used by an airflow command (that they don't use or care about) then I suppose that's up to them. But it's also likely going to be a mistake most of the time, so I think I'd lean more to making this a fatal exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org