You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by robertwb <gi...@git.apache.org> on 2016/07/12 17:45:56 UTC
[GitHub] incubator-beam pull request #639: Fixes bug due to accessing cached pvalues ...
GitHub user robertwb opened a pull request:
https://github.com/apache/incubator-beam/pull/639
Fixes bug due to accessing cached pvalues multiple times.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
This lookup is not an idempotent operation, as it decrements the
refcount and may even delete the pvalue from the cache. Instead,
we do the lookup once, storing the result in a map that is
referenced elsewhere.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertwb/incubator-beam fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/639.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #639
----
commit bfd67426a54509d108f2e6da5745ff702da96ff1
Author: Robert Bradshaw <ro...@google.com>
Date: 2016-07-12T17:43:29Z
Fixes bug due to accessing cached pvalues multiple times.
This lookup is not an idempotent operation, as it decrements the
refcount and may even delete the pvalue from the cache. Instead,
we do the lookup once, storing the result in a map that is
referenced elsewhere.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #639: [BEAM-441] Fixes bug due to accessing cach...
Posted by robertwb <gi...@git.apache.org>.
Github user robertwb closed the pull request at:
https://github.com/apache/incubator-beam/pull/639
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---