[GitHub] [superset] kgabryje commented on a change in pull request #14693: feat(native-filters): Highlight charts affected by focused native filter

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #14693:
URL: https://github.com/apache/superset/pull/14693#discussion_r635109689



##########
File path: superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx
##########
@@ -72,7 +72,7 @@ const DashboardContainer: FC<DashboardContainerProps> = ({ topLevelTabs }) => {
             activeKey={activeKey}
             renderTabBar={() => <></>}
             fullWidth={false}
-            animated
+            animated={false}

Review comment:
       I disabled animation as it was breaking native filters - when user switched tab, `margin-left: 100%` style was set on tab content, which was covering native filters panel, causing the user to be unable to click native filters... And the animation looked ugly with native filters panel anyway 😛 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org